linux-kernel - Re: [PATCH] trace/events/task.h: Replace strlcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFhGd8ruFyv=eL6XXY3FQWVAa3SAy=uBebLReGog0oSwE6XUiw@mail.gmail.com>
Date:   Thu, 31 Aug 2023 16:20:02 -0700
From:   Justin Stitt <justinstitt@...gle.com>
To:     Azeem Shaikh <azeemshaikh38@...il.com>
Cc:     Kees Cook <keescook@...omium.org>, linux-hardening@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH] trace/events/task.h: Replace strlcpy with strscpy

On Thu, Aug 31, 2023 at 12:42 PM Azeem Shaikh <azeemshaikh38@...il.com> wrote:
>
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
>
> No return values were used, so direct replacement is safe.
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> [2] https://github.com/KSPP/linux/issues/89
>
> Signed-off-by: Azeem Shaikh <azeemshaikh38@...il.com>

Reviewed-by: Justin Stitt <justinstitt@...gle.com>

> ---
>  include/trace/events/task.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/task.h b/include/trace/events/task.h
> index 64d160930b0d..47b527464d1a 100644
> --- a/include/trace/events/task.h
> +++ b/include/trace/events/task.h
> @@ -47,7 +47,7 @@ TRACE_EVENT(task_rename,
>         TP_fast_assign(
>                 __entry->pid = task->pid;
>                 memcpy(entry->oldcomm, task->comm, TASK_COMM_LEN);
> -               strlcpy(entry->newcomm, comm, TASK_COMM_LEN);
> +               strscpy(entry->newcomm, comm, TASK_COMM_LEN);
>                 __entry->oom_score_adj = task->signal->oom_score_adj;
>         ),
>
> --
> 2.42.0.283.g2d96d420d3-goog
>
>