linux-kernel - Re: [RFT PATCH] spi: bcm2835: reduce the abuse of the GPIO API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZPEhS0uBWABpaE+/@smile.fi.intel.com>
Date:   Fri, 1 Sep 2023 02:24:59 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Mark Brown <broonie@...nel.org>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>, linux-spi@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [RFT PATCH] spi: bcm2835: reduce the abuse of the GPIO API

On Thu, Aug 31, 2023 at 09:49:34PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> Currently the bcm2835 SPI driver uses functions meant for GPIO providers
> exclusively to locate the GPIO chip it gets its CS pins from and request
> the relevant pin. I don't know the background and what bug forced this.

...

>  	/*
> +	 * TODO: The code below is a slightly better alternative to the utter
> +	 * abuse of the GPIO API that I found here before. It creates a
> +	 * temporary lookup table, assigns it to the SPI device, gets the GPIO
> +	 * descriptor and then releases the lookup table.
>  	 *
> +	 * Still the real problem is unsolved. Looks like the cs_gpiods table
> +	 * is not assigned correctly from DT?
>  	 */

I'm not sure why this quirk is here. AFAIR the SPI CS quirks are located in
gpiolib-of.c.

-- 
With Best Regards,
Andy Shevchenko