linux-kernel - Re: [PATCH] rtc: brcmstb-waketimer: support level alarm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f96930c8-4ee4-398d-3930-cf25deb83d2a@broadcom.com>
Date:   Thu, 31 Aug 2023 16:27:58 -0700
From:   Florian Fainelli <florian.fainelli@...adcom.com>
To:     Doug Berger <opendmb@...il.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>, linux-rtc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: brcmstb-waketimer: support level alarm_irq

On 8/30/23 15:47, Doug Berger wrote:
> Some devices (e.g. BCM72112) use an alarm_irq interrupt that is
> connected to a level interrupt controller rather than an edge
> interrupt controller. In this case, the interrupt cannot be left
> enabled by the irq handler while preserving the hardware wake-up
> signal on wake capable devices or an interrupt storm will occur.
> 
> The alarm_expired flag is introduced to allow the disabling of
> the interrupt when an alarm expires and to support balancing the
> calls to disable_irq() and enable_irq() in accordance with the
> existing design.
> 
> Fixes: 24304a87158a ("rtc: brcmstb-waketimer: allow use as non-wake alarm")
> Signed-off-by: Doug Berger <opendmb@...il.com>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)