linux-kernel - Re: [PATCH] powerpc/85xx: Mark some functions static and add missing includes to fix no previous prototype error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169345455027.11824.1278535983200395426.b4-ty@ellerman.id.au>
Date:   Thu, 31 Aug 2023 14:02:30 +1000
From:   Michael Ellerman <patch-notifications@...erman.id.au>
To:     Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] powerpc/85xx: Mark some functions static and add missing includes to fix no previous prototype error

On Tue, 22 Aug 2023 08:13:13 +0200, Christophe Leroy wrote:
> corenet{32/64}_smp_defconfig leads to:
> 
>   CC      arch/powerpc/sysdev/ehv_pic.o
> arch/powerpc/sysdev/ehv_pic.c:45:6: error: no previous prototype for 'ehv_pic_unmask_irq' [-Werror=missing-prototypes]
>    45 | void ehv_pic_unmask_irq(struct irq_data *d)
>       |      ^~~~~~~~~~~~~~~~~~
> arch/powerpc/sysdev/ehv_pic.c:52:6: error: no previous prototype for 'ehv_pic_mask_irq' [-Werror=missing-prototypes]
>    52 | void ehv_pic_mask_irq(struct irq_data *d)
>       |      ^~~~~~~~~~~~~~~~
> arch/powerpc/sysdev/ehv_pic.c:59:6: error: no previous prototype for 'ehv_pic_end_irq' [-Werror=missing-prototypes]
>    59 | void ehv_pic_end_irq(struct irq_data *d)
>       |      ^~~~~~~~~~~~~~~
> arch/powerpc/sysdev/ehv_pic.c:66:6: error: no previous prototype for 'ehv_pic_direct_end_irq' [-Werror=missing-prototypes]
>    66 | void ehv_pic_direct_end_irq(struct irq_data *d)
>       |      ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/sysdev/ehv_pic.c:71:5: error: no previous prototype for 'ehv_pic_set_affinity' [-Werror=missing-prototypes]
>    71 | int ehv_pic_set_affinity(struct irq_data *d, const struct cpumask *dest,
>       |     ^~~~~~~~~~~~~~~~~~~~
> arch/powerpc/sysdev/ehv_pic.c:112:5: error: no previous prototype for 'ehv_pic_set_irq_type' [-Werror=missing-prototypes]
>   112 | int ehv_pic_set_irq_type(struct irq_data *d, unsigned int flow_type)
>       |     ^~~~~~~~~~~~~~~~~~~~
>   CC      arch/powerpc/sysdev/fsl_rio.o
> arch/powerpc/sysdev/fsl_rio.c:102:5: error: no previous prototype for 'fsl_rio_mcheck_exception' [-Werror=missing-prototypes]
>   102 | int fsl_rio_mcheck_exception(struct pt_regs *regs)
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/sysdev/fsl_rio.c:306:5: error: no previous prototype for 'fsl_map_inb_mem' [-Werror=missing-prototypes]
>   306 | int fsl_map_inb_mem(struct rio_mport *mport, dma_addr_t lstart,
>       |     ^~~~~~~~~~~~~~~
> arch/powerpc/sysdev/fsl_rio.c:357:6: error: no previous prototype for 'fsl_unmap_inb_mem' [-Werror=missing-prototypes]
>   357 | void fsl_unmap_inb_mem(struct rio_mport *mport, dma_addr_t lstart)
>       |      ^~~~~~~~~~~~~~~~~
> arch/powerpc/sysdev/fsl_rio.c:445:5: error: no previous prototype for 'fsl_rio_setup' [-Werror=missing-prototypes]
>   445 | int fsl_rio_setup(struct platform_device *dev)
>       |     ^~~~~~~~~~~~~
>   CC      arch/powerpc/sysdev/fsl_rmu.o
> arch/powerpc/sysdev/fsl_rmu.c:362:6: error: no previous prototype for 'msg_unit_error_handler' [-Werror=missing-prototypes]
>   362 | void msg_unit_error_handler(void)
>       |      ^~~~~~~~~~~~~~~~~~~~~~
>   CC      arch/powerpc/platforms/85xx/corenet_generic.o
> arch/powerpc/platforms/85xx/corenet_generic.c:33:13: error: no previous prototype for 'corenet_gen_pic_init' [-Werror=missing-prototypes]
>    33 | void __init corenet_gen_pic_init(void)
>       |             ^~~~~~~~~~~~~~~~~~~~
> arch/powerpc/platforms/85xx/corenet_generic.c:51:13: error: no previous prototype for 'corenet_gen_setup_arch' [-Werror=missing-prototypes]
>    51 | void __init corenet_gen_setup_arch(void)
>       |             ^~~~~~~~~~~~~~~~~~~~~~
> arch/powerpc/platforms/85xx/corenet_generic.c:104:12: error: no previous prototype for 'corenet_gen_publish_devices' [-Werror=missing-prototypes]
>   104 | int __init corenet_gen_publish_devices(void)
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>   CC      arch/powerpc/platforms/85xx/qemu_e500.o
> arch/powerpc/platforms/85xx/qemu_e500.c:28:13: error: no previous prototype for 'qemu_e500_pic_init' [-Werror=missing-prototypes]
>    28 | void __init qemu_e500_pic_init(void)
>       |             ^~~~~~~~~~~~~~~~~~
>   CC      arch/powerpc/kernel/pmc.o
> arch/powerpc/kernel/pmc.c:78:6: error: no previous prototype for 'power4_enable_pmcs' [-Werror=missing-prototypes]
>    78 | void power4_enable_pmcs(void)
>       |      ^~~~~~~~~~~~~~~~~~
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc/85xx: Mark some functions static and add missing includes to fix no previous prototype error
      https://git.kernel.org/powerpc/c/c265735ff5b1f13272e2bfb196f5c55f9b3c9bac

cheers