linux-kernel - Re: [GIT PULL] smb3 client fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2r5mv+UBHjRAuGRfsGeUvPaZ=bo0=yVWSYMVkbrkzqDZ+SwA@mail.gmail.com>
Date:   Wed, 30 Aug 2023 23:37:38 -0500
From:   Steve French <smfrench@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Dave Kleikamp <shaggy@...nel.org>,
        "Dr. David Alan Gilbert" <linux@...blig.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] smb3 client fixes

On Wed, Aug 30, 2023 at 11:21 PM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> I've pulled this, but I think the new NLS_UCS2_UTILS config option
> shouldn't be something that is asked about. The filesystems that want
> it already select it, and users shouldn't be asked about a module with
> no use.
>
> The way to do that is to simply not have a user query string for it,
> ie instead of
>
>   config NLS_UCS2_UTILS
>           tristate "NLS UCS-2 UTILS"
>
> it could be (an dI think should be) just
>
>   config NLS_UCS2_UTILS
>           tristate
>
> which tells the config system not to ask users about it.
>
> Because users really shouldn't be asked questions that there is no point in.

Agree.  Will fix

> And then, on a purely visual commentary about your pull request -
> lines like these are just noise:
>
> >  fs/{smb/server/uniupr.h => nls/nls_ucs2_utils.c} | 156
> > +++++-------------------------------------
> >  fs/nls/nls_ucs2_utils.h                          | 285
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> and the problem seems to be that you generate the diffstat in a very
> wide terminal (where git tries to be helpful and give you lots of
> detail), and then you cut-and-paste the result.
>
> If you pipe it to a tool instead (xsel, perhaps), git will limit the
> width of the diffstat to something sane.

Yes - today my terminal was set at about 180 character width.  Just
tried an experiment and piping to xsel did fix the output.  Will
update my scripts.


-- 
Thanks,

Steve