linux-kernel - Re: [PATCH v5 04/12] virt: geniezone: Add vcpu support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f978d5599b5b4b9e75685421e180500ad138ca3c.camel@mediatek.com>
Date:   Thu, 31 Aug 2023 06:54:48 +0000
From:   Yi-De Wu (吳一德) <Yi-De.Wu@...iatek.com>
To:     "robh@...nel.org" <robh@...nel.org>
CC:     "corbet@....net" <corbet@....net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        MY Chuang (莊明躍) <MY.Chuang@...iatek.com>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "quic_tsoni@...cinc.com" <quic_tsoni@...cinc.com>,
        Chi-shen Yeh (葉奇軒) 
        <Chi-shen.Yeh@...iatek.com>,
        Shawn Hsiao (蕭志祥) 
        <shawn.hsiao@...iatek.com>,
        PeiLun Suei (隋培倫) 
        <PeiLun.Suei@...iatek.com>,
        Liju-clr Chen (陳麗如) 
        <Liju-clr.Chen@...iatek.com>,
        Jades Shih (施向玨) 
        <jades.shih@...iatek.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "dbrazdil@...gle.com" <dbrazdil@...gle.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Yingshiuan Pan (潘穎軒) 
        <Yingshiuan.Pan@...iatek.com>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        Ze-yu Wang (王澤宇) 
        <Ze-yu.Wang@...iatek.com>, "will@...nel.org" <will@...nel.org>,
        Ivan Tseng (曾志軒) 
        <ivan.tseng@...iatek.com>
Subject: Re: [PATCH v5 04/12] virt: geniezone: Add vcpu support

On Fri, 2023-08-11 at 11:00 -0600, Rob Herring wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Thu, Jul 27, 2023 at 03:59:57PM +0800, Yi-De Wu wrote:
> > From: "Yingshiuan Pan" <yingshiuan.pan@...iatek.com>
> > 
> > VMM use this interface to create vcpu instance which is a fd, and
> this
> > fd will be for any vcpu operations, such as setting vcpu registers
> and
> > accepts the most important ioctl GZVM_VCPU_RUN which requests
> GenieZone
> > hypervisor to do context switch to execute VM's vcpu context.
> > 
> > Signed-off-by: Yingshiuan Pan <yingshiuan.pan@...iatek.com>
> > Signed-off-by: Jerry Wang <ze-yu.wang@...iatek.com>
> > Signed-off-by: Liju Chen <liju-clr.chen@...iatek.com>
> > Signed-off-by: Yi-De Wu <yi-de.wu@...iatek.com>
> > ---
> >  arch/arm64/geniezone/Makefile           |   2 +-
> >  arch/arm64/geniezone/gzvm_arch_common.h |  20 ++
> >  arch/arm64/geniezone/vcpu.c             |  88 +++++++++
> >  arch/arm64/geniezone/vm.c               |  11 ++
> >  arch/arm64/include/uapi/asm/gzvm_arch.h |  30 +++
> 
> I'm almost certain that the arm64 maintainers will reject putting
> this 
> here. What is the purpose of the split with drivers/virt/? Do you
> plan 
> to support another arch in the near future?
> 
> Yes, there's KVM stuff in arch/arm64, but that is multi-arch.
> 

hi Rob,

Thank you for the review, and the confirmation from Will was well
received. 

To be more specific, are you suggesting to 
- remove the `gzvm_arch.h`
from UAPI or 
- remove all the code under `arch/arm64/geniezone` to
somewhere like `drivers/virt/geniezone/arch`, or
- both? 

Regards,

> >  drivers/virt/geniezone/Makefile         |   3 +-
> >  drivers/virt/geniezone/gzvm_vcpu.c      | 250
> ++++++++++++++++++++++++
> >  drivers/virt/geniezone/gzvm_vm.c        |   5 +
> >  include/linux/gzvm_drv.h                |  21 ++
> >  include/uapi/linux/gzvm.h               | 136 +++++++++++++
> >  10 files changed, 564 insertions(+), 2 deletions(-)
> >  create mode 100644 arch/arm64/geniezone/vcpu.c
> >  create mode 100644 drivers/virt/geniezone/gzvm_vcpu.c