linux-kernel - Re: [PATCH] lib: error-inject: fix error check for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023083151-random-karma-fa97@gregkh>
Date:   Thu, 31 Aug 2023 10:10:33 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yi Yang <yiyang13@...wei.com>
Cc:     akpm@...ux-foundation.org, machel@...o.com, mhiramat@...nel.org,
        ast@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib: error-inject: fix error check for
 debugfs_create_file()

On Thu, Aug 31, 2023 at 03:56:53PM +0800, Yi Yang wrote:
> The debugfs_create_file() function returns error pointers, it never
> returns NULL, we need to check the return value correctly to avoid
> debugfs_remove() is not called.
> 
> Fixes: 540adea3809f ("error-injection: Separate error-injection from kprobe")
> Signed-off-by: Yi Yang <yiyang13@...wei.com>
> ---
>  lib/error-inject.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/error-inject.c b/lib/error-inject.c
> index 887acd9a6ea6..8bcdea5229eb 100644
> --- a/lib/error-inject.c
> +++ b/lib/error-inject.c
> @@ -219,7 +219,7 @@ static int __init ei_debugfs_init(void)
>  	dir = debugfs_create_dir("error_injection", NULL);
>  
>  	file = debugfs_create_file("list", 0444, dir, NULL, &ei_fops);
> -	if (!file) {
> +	if (IS_ERR(file)) {

As it is obvious this check has never failed, please just don't check
this at all, it's fine to never check the return value of this function.

thanks,

greg k-h