[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <205cfbcb-a989-dc72-8f5d-46d2a00b01d9@linaro.org>
Date: Thu, 31 Aug 2023 10:45:50 +0200
From: Philippe Mathieu-Daudé <philmd@...aro.org>
To: Stefan Hajnoczi <stefanha@...hat.com>, kvm@...r.kernel.org
Cc: David Laight <David.Laight@...LAB.COM>,
linux-kernel@...r.kernel.org, "Tian, Kevin" <kevin.tian@...el.com>,
Alex Williamson <alex.williamson@...hat.com>,
Jason Gunthorpe <jgg@...pe.ca>,
Jason Gunthorpe <jgg@...dia.com>
Subject: Re: [PATCH v2 1/3] vfio: trivially use __aligned_u64 for ioctl
structs
On 29/8/23 20:27, Stefan Hajnoczi wrote:
> u64 alignment behaves differently depending on the architecture and so
> <uapi/linux/types.h> offers __aligned_u64 to achieve consistent behavior
> in kernel<->userspace ABIs.
>
> There are structs in <uapi/linux/vfio.h> that can trivially be updated
> to __aligned_u64 because the struct sizes are multiples of 8 bytes.
> There is no change in memory layout on any CPU architecture and
> therefore this change is safe.
>
> The commits that follow this one handle the trickier cases where
> explanation about ABI breakage is necessary.
>
> Suggested-by: Jason Gunthorpe <jgg@...dia.com>
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@...hat.com>
> ---
> include/uapi/linux/vfio.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>
Powered by blists - more mailing lists