linux-kernel - Re: mainline build failure due to c8171a86b274 ("csky: Fixup -Wmissing-prototypes warning")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJF2gTQWWi_Cb1iQiLOr4114kZW7L93KNwjCu3ArKb7ffxcO+A@mail.gmail.com>
Date:   Thu, 31 Aug 2023 09:15:30 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Linux regressions mailing list <regressions@...ts.linux.dev>
Cc:     "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@...il.com>,
        Guo Ren <guoren@...ux.alibaba.com>,
        Oleg Nesterov <oleg@...hat.com>, linux-csky@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: mainline build failure due to c8171a86b274 ("csky: Fixup
 -Wmissing-prototypes warning")

On Wed, Aug 30, 2023 at 9:07 PM Linux regression tracking (Thorsten
Leemhuis) <regressions@...mhuis.info> wrote:
>
> On 30.08.23 13:40, Sudip Mukherjee (Codethink) wrote:
> >
> > The latest mainline kernel branch fails to build csky allmodconfig with
> > the error:
>
> Thx for the report and involving regzbot. To make one thing more obvious:
>
> Guo Ren, it seems to be caused by a commit of yours.
>
> And fun fact: seem 0day bot found the same problem nearly thee weeks
> ago, but nobody cared afaics:
> https://lore.kernel.org/all/202308120502.MXpchFC1-lkp@intel.com/
>
> Ciao, Thorsten
>
> > In file included from ./arch/csky/include/asm/ptrace.h:7,
> >                  from ./arch/csky/include/asm/processor.h:8,
> >                  from ./include/linux/prefetch.h:15,
> >                  from drivers/net/ethernet/intel/i40e/i40e_txrx.c:4:
> > ./arch/csky/include/asm/traps.h:43:11: error: expected ';' before 'void'
> >    43 | asmlinkage void do_trap_unknown(struct pt_regs *regs);
> >       |           ^~~~~
> >       |           ;
> > ./arch/csky/include/asm/traps.h:44:11: error: expected ';' before 'void'
> >    44 | asmlinkage void do_trap_zdiv(struct pt_regs *regs);
> >       |           ^~~~~
> >       |           ;
> > ./arch/csky/include/asm/traps.h:45:11: error: expected ';' before 'void'
> >    45 | asmlinkage void do_trap_buserr(struct pt_regs *regs);
> >       |           ^~~~~
> >       |           ;
> > ./arch/csky/include/asm/traps.h:46:11: error: expected ';' before 'void'
> >    46 | asmlinkage void do_trap_misaligned(struct pt_regs *regs);
> >       |           ^~~~~
> >       |           ;
> > ./arch/csky/include/asm/traps.h:47:11: error: expected ';' before 'void'
> >    47 | asmlinkage void do_trap_bkpt(struct pt_regs *regs);
> >       |           ^~~~~
> >       |           ;
> > ./arch/csky/include/asm/traps.h:48:11: error: expected ';' before 'void'
> >    48 | asmlinkage void do_trap_illinsn(struct pt_regs *regs);
> >       |           ^~~~~
> >       |           ;
> > ./arch/csky/include/asm/traps.h:49:11: error: expected ';' before 'void'
> >    49 | asmlinkage void do_trap_fpe(struct pt_regs *regs);
> >       |           ^~~~~
> >       |           ;
> > ./arch/csky/include/asm/traps.h:50:11: error: expected ';' before 'void'
> >    50 | asmlinkage void do_trap_priv(struct pt_regs *regs);
> >       |           ^~~~~
> >       |           ;
> > ./arch/csky/include/asm/traps.h:51:11: error: expected ';' before 'void'
> >    51 | asmlinkage void trap_c(struct pt_regs *regs);
> >       |           ^~~~~
> >       |           ;
> > ./arch/csky/include/asm/traps.h:53:11: error: expected ';' before 'void'
> >    53 | asmlinkage void do_notify_resume(struct pt_regs *regs,
> >       |           ^~~~~
> >       |           ;
> > In file included from ./arch/csky/include/asm/processor.h:8,
> >                  from ./include/linux/prefetch.h:15,
> >                  from drivers/net/ethernet/intel/i40e/i40e_txrx.c:4:
> > ./arch/csky/include/asm/ptrace.h:99:11: error: expected ';' before 'int'
> >    99 | asmlinkage int syscall_trace_enter(struct pt_regs *regs);
> >       |           ^~~~
> >       |           ;
> > ./arch/csky/include/asm/ptrace.h:100:11: error: expected ';' before 'void'
> >   100 | asmlinkage void syscall_trace_exit(struct pt_regs *regs);
> >       |           ^~~~~
> >       |           ;
> >
> > git bisect pointed to c8171a86b274 ("csky: Fixup -Wmissing-prototypes warning").
> >
> > Reverting the commit has fixed the build failure.
> >
> > I will be happy to test any patch or provide any extra log if needed.
> >
> > #regzbot introduced: c8171a86b27401aa1f492dd1f080f3102264f1ab
>
> #regzbot monitor:
> https://lore.kernel.org/all/202308120502.MXpchFC1-lkp@intel.com/

Sorry, Fixes have been sent, I'm waiting for it into the linux-next,
and then I will send 2nd pull request.

https://lore.kernel.org/linux-csky/20230830094653.2833443-1-guoren@kernel.org/

-- 
Best Regards
 Guo Ren