linux-kernel - Re: [PATCH v4 0/4] Modify die() for MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <500758f7-f749-469b-1419-0c08b01c9eab@flygoat.com>
Date:   Thu, 31 Aug 2023 18:38:07 +0800
From:   Jiaxun Yang <jiaxun.yang@...goat.com>
To:     "Maciej W. Rozycki" <macro@...am.me.uk>,
        Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     linux-mips@...r.kernel.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-kernel@...r.kernel.org, loongson-kernel@...ts.loongnix.cn
Subject: Re: [PATCH v4 0/4] Modify die() for MIPS



在 2023/8/29 23:19, Thomas Bogendoerfer 写道:
> On Mon, Aug 28, 2023 at 11:11:19AM +0200, Thomas Bogendoerfer wrote:
>> On Sat, Aug 19, 2023 at 04:36:19PM +0800, Tiezhu Yang wrote:
>>> v4:
>>>    -- Add BUG() at the end of nmi_exception_handler()
>>>    -- Return earlier in die() if notify_die() returns NOTIFY_STOP
>>>    -- Update the patch titles and commit messages
>>>
>>> v3:
>>>    -- Make each patch can be built without errors and warnings.
>>>
>>> v2:
>>>    -- Update the commit message to give more detailed info, split into
>>>       three individual patches, suggested by Maciej, thank you.
>>>
>>> Tiezhu Yang (4):
>>>    MIPS: Add BUG() at the end of nmi_exception_handler()
>>>    MIPS: Do not kill the task in die() if notify_die() returns
>>>      NOTIFY_STOP
>>>    MIPS: Return earlier in die() if notify_die() returns NOTIFY_STOP
>>>    MIPS: Add identifier names to arguments of die() declaration
>>>
>>>   arch/mips/include/asm/ptrace.h |  2 +-
>>>   arch/mips/kernel/traps.c       | 15 +++++++++------
>>>   2 files changed, 10 insertions(+), 7 deletions(-)
>> series applied to mips-next.
> I've dropped the series again after feedback from Maciej, that this
> still needs more changes.
Was the feedback made off-list?

I think it's important to make submitter aware of the problem before
action being taken.

 From my perspective Teizhu was working hard to address review comments
all the way so it looks unfair to neglect his work without transparent 
communication.

Thanks
- Jiaxun
> Thomas.