linux-kernel - Possible cut'n'paste error in linux-6.5/drivers/thunderbolt/tmu.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6P189MB056829997A31D4B968AEA77C9CE5A@DB6P189MB0568.EURP189.PROD.OUTLOOK.COM>
Date:   Thu, 31 Aug 2023 11:02:58 +0000
From:   David Binderman <dcb314@...mail.com>
To:     "andreas.noever@...il.com" <andreas.noever@...il.com>,
        "michael.jamet@...el.com" <michael.jamet@...el.com>,
        "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "YehezkelShB@...il.com" <YehezkelShB@...il.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Possible cut'n'paste error in linux-6.5/drivers/thunderbolt/tmu.c

Hello there,

I just tried out static analyser cppcheck on linux-6.5. It said:

linux-6.5/drivers/thunderbolt/tmu.c:385:50: style: Expression is always false because 'else if' condition matches previous condition at line 383. [multiCondition]

Source code is

            if (tmu_rates[TB_SWITCH_TMU_MODE_LOWRES] == rate)
                sw->tmu.mode = TB_SWITCH_TMU_MODE_LOWRES;
            else if (tmu_rates[TB_SWITCH_TMU_MODE_LOWRES] == rate)
                sw->tmu.mode = TB_SWITCH_TMU_MODE_HIFI_UNI;

Regards

David Binderman