linux-kernel - Re: [PATCH 5/9] regulator/core: regulator_ena_gpio_ctrl: pull in ena

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4434c869-6ef5-40b4-869d-8e4d292ac30e@sirena.org.uk>
Date:   Thu, 31 Aug 2023 12:13:16 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/9] regulator/core: regulator_ena_gpio_ctrl: pull in
 ena_gpio state handling

On Wed, Aug 30, 2023 at 11:38:56PM +0200, Michał Mirosław wrote:

> -		if (pin->enable_count > 1) {
> -			pin->enable_count--;
> -			return 0;
> -		}
> -
>  		/* Disable GPIO if not used */
> -		if (pin->enable_count <= 1) {
> +		if (pin->enable_count-- <= 1) {

The goal isn't to write the minimum number of lines possible - this just
makes the logic harder to follow and for bonus points isn't obviously
related to the chnages described in changelog.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)