linux-kernel - Re: [PATCH v3 1/1] i3c: master: svc: fix probe failure when no i3c device exist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230831162134.6ccbaf23@xps-13>
Date:   Thu, 31 Aug 2023 16:21:34 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Frank Li <Frank.Li@....com>
Cc:     alexandre.belloni@...tlin.com, conor.culhane@...vaco.com,
        imx@...ts.linux.dev, linux-i3c@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/1] i3c: master: svc: fix probe failure when no i3c
 device exist

Hi Frank,

Frank.Li@....com wrote on Thu, 31 Aug 2023 10:13:24 -0400:

> I3C masters are expected to support hot-join. This means at initialization
> time we might not yet discover any device and this should not be treated
> as a fatal error.
> 
> During the DAA procedure which happens at probe time, if no device has
> joined, all CCC will be NACKed (from a bus perspective). This leads to an
> early return with an error code which fails the probe of the master.
> 
> Let's avoid this by just telling the core through an I3C_ERROR_M2
> return command code that no device was discovered, which is a valid
> situation. This way the master will no longer bail out and fail to probe
> for a wrong reason.
> 
> Cc: stable@...r.kernel.org
> Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
> Signed-off-by: Frank Li <Frank.Li@....com>

Acked-by: Miquel Raynal <miquel.raynal@...tlin.com>

Thanks,
Miquèl