linux-kernel - Re: [PATCH] ssb-main: Fix division by zero in ssb_calc_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <763366419.1280837.1693491918477.JavaMail.zimbra@confident.ru>
Date:   Thu, 31 Aug 2023 17:25:18 +0300 (MSK)
From:   Ранд Дееб <deeb.rand@...fident.ru>
To:     Krzysztof Kozlowski <krzk@...nel.org>, Michael Buesch <m@...s.ch>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Cc:     lvc-project <lvc-project@...uxtesting.org>,
        Воскресенский Станислав Игоревич 
        <voskresenski.stanislav@...fident.ru>
Subject: Re: [PATCH] ssb-main: Fix division by zero in ssb_calc_clock_rate()

Dear Krzysztof,

Thank you for your response, now I see, but we already used the standard 
tool git send-email to send the patch. It seems we have to set the 
transfer-encoding manually (not default), we will fix it next time.
It's our first time trying to send a patch.

Best Regards,
Rand

----- Original Message -----
From: "Krzysztof Kozlowski" <krzk@...nel.org>
To: "Rand Deeb" <deeb.rand@...fident.ru>, "Michael Buesch" <m@...s.ch>, "linux-wireless" <linux-wireless@...r.kernel.org>, "linux-kernel" <linux-kernel@...r.kernel.org>
Cc: "lvc-project" <lvc-project@...uxtesting.org>, "Воскресенский Станислав Игоревич" <voskresenski.stanislav@...fident.ru>
Sent: Thursday, August 31, 2023 4:45:15 PM
Subject: Re: [PATCH] ssb-main: Fix division by zero in ssb_calc_clock_rate()

On 30/08/2023 10:27, Rand Deeb wrote:
> In ssb_calc_clock_rate(), the value of m1 may be zero because it is
> initialized using clkfactor_f6_resolv(). This function could return
> zero, so there is a possibility of dividing by zero, we fixed it by
> checking the values before dividing.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.

Version your patches and provide changelog after --- .

> 
> Signed-off-by: Rand Deeb <deeb.rand@...fident.ru>
> ---
>  drivers/ssb/main.c | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index 0a26984acb2c..e0776a16d04d 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -903,13 +903,21 @@ u32 ssb_calc_clock_rate(u32 plltype, u32 n, u32 m)
>  		case SSB_CHIPCO_CLK_MC_BYPASS:
>  			return clock;
>  		case SSB_CHIPCO_CLK_MC_M1:
> -			return (clock / m1);
> +			if (m1 !=3D 0)

Nothing improved here.

Don't send patches as quoted-printable via some weird mailers.
Recommendation is to use standard tool - git send-email.

As you can easily see on the web - it is re-formatted for quoted-printable:

https://lore.kernel.org/all/20230830082759.23336-1-deeb.rand@confident.ru/raw

Best regards,
Krzysztof