linux-kernel - Re: [PATCH 5.10 00/84] 5.10.193-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a69c0c0-5e8a-9a3a-6527-3eb7e51a955e@gmail.com>
Date:   Thu, 31 Aug 2023 07:54:06 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Manuel Lauss <manuel.lauss@...il.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        stable <stable@...r.kernel.org>, patches@...ts.linux.dev,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>, shuah@...nel.org,
        patches@...nelci.org, lkft-triage@...ts.linaro.org,
        Pavel Machek <pavel@...x.de>, jonathanh@...dia.com,
        sudipm.mukherjee@...il.com, srw@...dewatkins.net, rwarsow@....de,
        conor@...nel.org, Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: Re: [PATCH 5.10 00/84] 5.10.193-rc1 review



On 8/31/2023 3:31 AM, Greg Kroah-Hartman wrote:
> On Wed, Aug 30, 2023 at 07:38:09PM +0200, Manuel Lauss wrote:
>> Hello all,
>>
>> Florian Fainelli <f.fainelli@...il.com> schrieb am Mi., 30. Aug. 2023, 19:07:
>>>
>>> + Manuel,
>>>
>>> On 8/30/23 09:01, Guenter Roeck wrote:
>>>> On 8/30/23 03:52, Greg Kroah-Hartman wrote:
>>>>> On Mon, Aug 28, 2023 at 09:42:11AM -0700, Guenter Roeck wrote:
>>>>>> On 8/28/23 03:13, Greg Kroah-Hartman wrote:
>>>>>>> This is the start of the stable review cycle for the 5.10.193 release.
>>>>>>> There are 84 patches in this series, all will be posted as a response
>>>>>>> to this one.  If anyone has any issues with these being applied, please
>>>>>>> let me know.
>>>>>>>
>>>>>>> Responses should be made by Wed, 30 Aug 2023 10:11:30 +0000.
>>>>>>> Anything received after that time might be too late.
>>>>>>>
>>>>>>
>>>>>> FWIW, commit 619672bf2d04 ("MIPS: Alchemy: fix dbdma2") should be
>>>>>> reverted
>>>>>> v5.10.y since it doesn't fix anything but breaks the build for
>>>>>> affected boards
>>>>>> completely.
>>>>>>
>>>>>> arch/mips/alchemy/common/dbdma.c: In function 'au1xxx_dbdma_put_source':
>>>>>> arch/mips/alchemy/common/dbdma.c:632:14: error:
>>>>>> 'dma_default_coherent' undeclared
>>>>>>
>>>>>> There is no 'dma_default_coherent' in v5.10.y.
>>>>>
>>>>> But that was added in 5.10.185, from back in June.  What changed to
>>>>> suddenly cause this to fail now?
>>>>>
>>>>
>>>> Nothing. I started to build this configuration and tracked down the
>>>> problem after the build failure was reported by others. Sorry, I didn't
>>>> initially realize that this is an old problem.
>>>
>>> We could back port 6d4e9a8efe3d59f31367d79e970c2f328da139a4 ("driver
>>> core: lift dma_default_coherent into common code") but that won't work
>>> too well on 4.14 or 4.19. I believe it would be simpler to adjust the
>>> branches with this patch, Manuel does that work?
>>
>> Please drop this patch from all stable releases. I didn't CC stable
>> when I submitted it,
>> and have no idea why it ended up there anyway.
>> It was intended to fix a problem initially found in 5.18 (I think).
> 
> I'm going to revert it now, thanks!

I prepared reverts yesterday that I can send out if you want?
-- 
Florian