linux-kernel - Re: [PATCH 1/3] mm: use nth_page() in place of direct struct page manipulation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <31F029DA-E93C-49B5-9062-5010B0F5ADB5@nvidia.com>
Date:   Thu, 31 Aug 2023 11:37:56 -0400
From:   Zi Yan <ziy@...dia.com>
To:     Muchun Song <muchun.song@...ux.dev>
Cc:     Linux-MM <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>,
        linux-mips@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "\"Matthew Wilcox (Oracle)\"" <willy@...radead.org>,
        David Hildenbrand <david@...hat.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        "\"Mike Rapoport (IBM)\"" <rppt@...nel.org>
Subject: Re: [PATCH 1/3] mm: use nth_page() in place of direct struct page
 manipulation.

On 31 Aug 2023, at 3:14, Muchun Song wrote:

>> On Aug 31, 2023, at 02:27, Zi Yan <zi.yan@...t.com> wrote:
>>
>> From: Zi Yan <ziy@...dia.com>
>>
>> When dealing with hugetlb pages, manipulating struct page pointers
>> directly can get to wrong struct page, since struct page is not guaranteed
>> to be contiguous on SPARSEMEM without VMEMMAP. Use nth_page() to handle
>> it properly.
>>
>> Signed-off-by: Zi Yan <ziy@...dia.com>
>
> Reviewed-by: Muchun Song <songmuchun@...edance.com>
>
> Maybe 3 separate patches would be better for backporting purpose.
Sure. Will split it and add Fixes in the next version.

--
Best Regards,
Yan, Zi

Download attachment "signature.asc" of type "application/pgp-signature" (855 bytes)