[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230831-defrost-rebalance-5efda5e5ff5c@spud>
Date: Thu, 31 Aug 2023 16:54:30 +0100
From: Conor Dooley <conor@...nel.org>
To: Naresh Solanki <naresh.solanki@...ements.com>
Cc: Guenter Roeck <linux@...ck-us.net>,
Jean Delvare <jdelvare@...e.com>,
krzysztof.kozlowski+dt@...aro.org,
Rob Herring <robh+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
linux-hwmon@...r.kernel.org,
Patrick Rudolph <patrick.rudolph@...ements.com>,
Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: hwmon: Add Infineon TDA38640
On Thu, Aug 31, 2023 at 12:49:32AM +0530, Naresh Solanki wrote:
> Hi
>
> On Wed, 30 Aug 2023 at 21:02, Conor Dooley <conor@...nel.org> wrote:
> > On Wed, Aug 30, 2023 at 12:36:16PM +0200, Naresh Solanki wrote:
> > > + Indicates that the chip ENABLE pin is at fixed level or left
> > > + unconnected(has internal pull-down).
> >
> > Maybe you've already been over this, but if the pin is called "enable"
> > why not use the same wording in the property?
> EN & ENABLE is used interchangeably in the datasheet.
Maybe we can go 1 for 2 in terms of consistency then, rather than 0 for
2.
> Just to keep property name short I use EN.
Consistency & readability trump brevity. Please pick one term, or point
out that this is called two things in the datasheet.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists