[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZPC8fJxQsRqJKK7k@smile.fi.intel.com>
Date: Thu, 31 Aug 2023 19:14:52 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Biju Das <biju.das.jz@...renesas.com>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Robert Foss <rfoss@...nel.org>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Douglas Anderson <dianders@...omium.org>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>, Zhu Wang <wangzhu9@...wei.com>,
Adrián Larumbe <adrian.larumbe@...labora.com>,
Thierry Reding <treding@...dia.com>,
Ville Syrjälä
<ville.syrjala@...ux.intel.com>,
Guillaume BRUN <the.cheaterman@...il.com>,
Rob Herring <robh@...nel.org>, Sandor Yu <Sandor.yu@....com>,
Sam Ravnborg <sam@...nborg.org>, Ondrej Jirman <megi@....cz>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around
of_node pointers
On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote:
> Having conditional around the of_node pointers turns out to make driver
> code use ugly #ifdef and #if blocks. So drop the conditionals.
...
> anx78xx->bridge.of_node = client->dev.of_node;
> panel_bridge->bridge.of_node = panel->dev->of_node;
> hdmi->bridge.of_node = pdev->dev.of_node;
> dsi->bridge.of_node = pdev->dev.of_node;
Yeah, I would really switch all of these to
bridge->fwnode = dev_fwnode(...);
But it's a suggestion for a separate change that I think can happen
sooner than later.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists