[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230831162042.471801-1-vkarpovi@opensource.cirrus.com>
Date: Thu, 31 Aug 2023 11:20:39 -0500
From: Vlad Karpovich <vkarpovi@...nsource.cirrus.com>
To: James Schulman <james.schulman@...rus.com>,
David Rhodes <david.rhodes@...rus.com>,
Richard Fitzgerald <rf@...nsource.cirrus.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, Rob Herring <robh+dt@...nel.org>
CC: <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
"Ricardo Rivera-Matos" <rriveram@...nsource.cirrus.com>,
Vlad Karpovich <vkarpovi@...nsource.cirrus.com>
Subject: [PATCH v3 1/4] ASoC: cs35l45: Checks index of cs35l45_irqs[]
From: Ricardo Rivera-Matos <rriveram@...nsource.cirrus.com>
Checks the index computed by the virq offset before printing the
error condition in cs35l45_spk_safe_err() handler.
Signed-off-by: Ricardo Rivera-Matos <rriveram@...nsource.cirrus.com>
Signed-off-by: Vlad Karpovich <vkarpovi@...nsource.cirrus.com>
---
sound/soc/codecs/cs35l45.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs35l45.c b/sound/soc/codecs/cs35l45.c
index 2ac4612402eb..02b1172d2647 100644
--- a/sound/soc/codecs/cs35l45.c
+++ b/sound/soc/codecs/cs35l45.c
@@ -1023,7 +1023,10 @@ static irqreturn_t cs35l45_spk_safe_err(int irq, void *data)
i = irq - regmap_irq_get_virq(cs35l45->irq_data, 0);
- dev_err(cs35l45->dev, "%s condition detected!\n", cs35l45_irqs[i].name);
+ if (i < 0 || i >= ARRAY_SIZE(cs35l45_irqs))
+ dev_err(cs35l45->dev, "Unspecified global error condition (%d) detected!\n", irq);
+ else
+ dev_err(cs35l45->dev, "%s condition detected!\n", cs35l45_irqs[i].name);
return IRQ_HANDLED;
}
--
2.25.1
Powered by blists - more mailing lists