linux-kernel - Re: [PATCH v4 4/4] dt-bindings: input: touchscreen: st1232: add example with touch-overlay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230831162201.GA2381101-robh@kernel.org>
Date:   Thu, 31 Aug 2023 11:22:01 -0500
From:   Rob Herring <robh@...nel.org>
To:     Javier Carrasco <javier.carrasco@...fvision.net>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Henrik Rydberg <rydberg@...math.org>,
        Bastian Hecht <hechtb@...il.com>,
        Michael Riesch <michael.riesch@...fvision.net>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v4 4/4] dt-bindings: input: touchscreen: st1232: add
 example with touch-overlay

On Thu, Aug 24, 2023 at 03:17:12PM +0200, Javier Carrasco wrote:
> The st1232 driver supports the overlay-touchscreen and overlay-buttons
> objects defined in the generic touchscreen bindings and implemented in
> the touch-overlay module. Add an example where nodes for an overlay
> touchscreen and overlay buttons are defined.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco@...fvision.net>
> ---
>  .../input/touchscreen/sitronix,st1232.yaml         | 40 ++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml b/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml
> index 1d8ca19fd37a..857b611f84c2 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/sitronix,st1232.yaml
> @@ -48,3 +48,43 @@ examples:
>                      gpios = <&gpio1 166 0>;
>              };
>      };
> +  - |
> +    #include <dt-bindings/input/linux-event-codes.h>
> +    i2c {
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            touchscreen@55 {
> +                    compatible = "sitronix,st1232";
> +                    reg = <0x55>;
> +                    interrupts = <2 0>;
> +                    gpios = <&gpio1 166 0>;

Just add this to the existing example. No value in 2 examples.

> +
> +                    overlay-touchscreen {
> +                            x-origin = <0>;
> +                            x-size = <240>;
> +                            y-origin = <40>;
> +                            y-size = <280>;
> +                    };
> +
> +                    overlay-buttons {
> +                            button-light {
> +                                    label = "Camera light";
> +                                    linux,code = <KEY_LIGHTS_TOGGLE>;
> +                                    x-origin = <40>;
> +                                    x-size = <40>;
> +                                    y-origin = <0>;
> +                                    y-size = <40>;
> +                            };
> +
> +                            button-power {
> +                                    label = "Power";
> +                                    linux,code = <KEY_POWER>;
> +                                    x-origin = <160>;
> +                                    x-size = <40>;
> +                                    y-origin = <0>;
> +                                    y-size = <40>;
> +                            };
> +                    };
> +            };
> +    };
> 
> -- 
> 2.39.2
>