linux-kernel - Re: [PATCH v14 3/9] dt-bindings: soc: qcom: cpr3: Add bindings for CPR3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1f60df1-7632-48a2-a211-dcd6c1fa419f@linaro.org>
Date:   Thu, 31 Aug 2023 18:40:53 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Rob Herring <robh@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd <sboyd@...nel.org>,
        Niklas Cassel <nks@...wful.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Robert Marko <robimarko@...il.com>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
        Jeffrey Hugo <quic_jhugo@...cinc.com>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>
Subject: Re: [PATCH v14 3/9] dt-bindings: soc: qcom: cpr3: Add bindings for
 CPR3 driver

On 31.08.2023 18:28, Rob Herring wrote:
> On Tue, Aug 29, 2023 at 01:01:44PM +0200, Ulf Hansson wrote:
>> On Mon, 28 Aug 2023 at 13:42, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>>>
>>> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
>>>
>>> Add the bindings for the CPR3 driver to the documentation.
>>>
>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
>>> [Konrad: Make binding check pass; update AGdR's email]
>>> Tested-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>>> ---
>>>  .../devicetree/bindings/soc/qcom/qcom,cpr3.yaml    | 286 +++++++++++++++++++++
>>>  1 file changed, 286 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
>>> new file mode 100644
>>> index 000000000000..acf2e294866b
>>
>> [...]
>>
>>> +
>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/clock/qcom,gcc-msm8998.h>
>>> +    #include <dt-bindings/interrupt-controller/irq.h>
>>> +
>>> +    cpus {
>>> +        #address-cells = <2>;
>>> +        #size-cells = <0>;
>>> +
>>> +        cpu@0 {
>>> +            compatible = "qcom,kryo280";
>>> +            device_type = "cpu";
>>> +            reg = <0x0 0x0>;
>>> +            operating-points-v2 = <&cpu0_opp_table>;
>>> +            power-domains = <&apc_cprh 0>;
>>> +            power-domain-names = "cprh";
>>
>> Rather than using a Qcom specific power-domain-name, perhaps a common
>> power-domain-name for cpus, that can be used for "the performance
>> domain" would be a good idea here?
>>
>> I have suggested using "perf" for the SCMI performance domain [1],
>> perhaps that description should be extended to cover this and other
>> performance domains too?
> 
> Better yet, nothing. There's no value to -names when there is only 1 
> entry.
As of today, it's required for devm_pm_opp_attach_genpd()

Ulf, is there a better way to do this that doesn't require names?

Konrad