linux-kernel - Re: [PATCH v2 1/4] ASoC: cs35l45: Checks index of cs35l45

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d97094c6-1534-05ad-0452-c627d7c45802@opensource.cirrus.com>
Date:   Thu, 31 Aug 2023 16:22:52 +0100
From:   Richard Fitzgerald <rf@...nsource.cirrus.com>
To:     "Rivera-Matos, Ricardo" <rriveram@...nsource.cirrus.com>,
        Mark Brown <broonie@...nel.org>
CC:     Vlad Karpovich <vkarpovi@...nsource.cirrus.com>,
        James Schulman <james.schulman@...rus.com>,
        David Rhodes <david.rhodes@...rus.com>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>, Rob Herring <robh+dt@...nel.org>,
        <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] ASoC: cs35l45: Checks index of cs35l45_irqs[]

On 31/8/23 15:56, Rivera-Matos, Ricardo wrote:
> Hello Mark,
> 
>> On Aug 30, 2023, at 3:59 PM, Mark Brown <broonie@...nel.org> wrote:
>>
>> On Wed, Aug 30, 2023 at 02:55:33PM -0500, Vlad Karpovich wrote:
>>> Checks the index computed by the virq offset before printing the
>>> error condition in cs35l45_spk_safe_err() handler.
>>>
>>> Signed-off-by: Ricardo Rivera-Matos <rriveram@...nsource.cirrus.com>
>>> Signed-off-by: Vlad Karpovich <vkarpovi@...nsource.cirrus.com>
>>
>> Who actually wrote this patch?
> 
> I am the original author, allow me to clarify how and why this is supposed to work.
> 

I think Mark's comment is that the Signed-off-by chain doesn't match
the patch author. The s-o-b order implies that Ricardo wrote it and
Vlad is upstreaming it - but in that case this email should start with
a From: line to say that the author is Ricardo.