linux-kernel - RE: [PATCH v5 8/8] selftests/resctrl: Adjust effective L3 cache size when SNC enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB608325D10C22A7EAE1C31C42FCE5A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date:   Thu, 31 Aug 2023 17:04:31 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     "Wieczor-Retman, Maciej" <maciej.wieczor-retman@...el.com>
CC:     "Yu, Fenghua" <fenghua.yu@...el.com>,
        "Chatre, Reinette" <reinette.chatre@...el.com>,
        Peter Newman <peternewman@...gle.com>,
        "Jonathan Corbet" <corbet@....net>,
        Shuah Khan <skhan@...uxfoundation.org>,
        "x86@...nel.org" <x86@...nel.org>,
        Shaopeng Tan <tan.shaopeng@...itsu.com>,
        James Morse <james.morse@....com>,
        Jamie Iles <quic_jiles@...cinc.com>,
        "Babu Moger" <babu.moger@....com>,
        Randy Dunlap <rdunlap@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "patches@...ts.linux.dev" <patches@...ts.linux.dev>
Subject: RE: [PATCH v5 8/8] selftests/resctrl: Adjust effective L3 cache size
 when SNC enabled

> So it would look like this:
>
>       while ((fscanf(fp, "%x", c)) != EOF ) {
>           if (c > 0xF)
>                   continue;
>           count = __builtin_popcount(c);
>       }
>
> Are there some problems with an approach like that?

I think I'd prefer something that does more checking on the input
(e.g. the hex numbers are separated by "," and terminated with
a '\n').

If Shuah Khan doesn't like my original patch I can re-write
to use fscanf() et. al.

-Tony