linux-kernel - Re: [PATCH v1 0/3] perf list/debug output fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fWdH_1or1yhH3pqFymnK=-w=OTzx63mVgknFNgqxf6T+A@mail.gmail.com>
Date:   Thu, 31 Aug 2023 11:41:51 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     "Liang, Kan" <kan.liang@...ux.intel.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Rob Herring <robh@...nel.org>,
        James Clark <james.clark@....com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 0/3] perf list/debug output fixes

On Thu, Aug 31, 2023 at 11:28 AM Liang, Kan <kan.liang@...ux.intel.com> wrote:
>
>
>
> On 2023-08-31 3:14 a.m., Ian Rogers wrote:
> > Fix a long standing parse_events_term cloning bug so that the bad
> > display of terms can be fixed and the code somewhat more intuitive:
> > https://lore.kernel.org/lkml/20230830070753.1821629-2-irogers@google.com/
> >
>
> Tested-by: Kan Liang <kan.liang@...ux.intel.com>

Thanks Kan!
Ian

> Thanks,
> Kan
>
> > Fix a bug caused by the rename of 'cpu' to 'default_core' in perf list.
> >
> > Add more documentation, increase type safety and fix some related bugs
> > where terms weren't initialized properly.
> >
> > Ian Rogers (3):
> >   perf list: Don't print Unit for default_core
> >   perf parse-events: Name the two term enums
> >   perf parse-events: Fix propagation of term's no_value when cloning
> >
> >  tools/perf/builtin-list.c      |   2 +-
> >  tools/perf/util/parse-events.c | 203 +++++++++++++++++++++++----------
> >  tools/perf/util/parse-events.h |  60 +++++++---
> >  tools/perf/util/parse-events.l |   2 +-
> >  tools/perf/util/parse-events.y |  27 +++--
> >  tools/perf/util/pmu.c          |   2 +-
> >  6 files changed, 207 insertions(+), 89 deletions(-)
> >