[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bbb42f12-fcb5-ade6-ab67-60a4cdb29c43@quicinc.com>
Date: Thu, 31 Aug 2023 08:40:48 +0530
From: Nitheesh Sekar <quic_nsekar@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: <agross@...nel.org>, <andersson@...nel.org>,
<konrad.dybcio@...aro.org>, <vkoul@...nel.org>,
<kishon@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<gregkh@...uxfoundation.org>, <quic_srichara@...cinc.com>,
<quic_varada@...cinc.com>, <quic_wcheng@...cinc.com>,
<linux-arm-msm@...r.kernel.org>, <linux-phy@...ts.infradead.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-usb@...r.kernel.org>,
Amandeep Singh <quic_amansing@...cinc.com>
Subject: Re: [PATCH V2 3/4] arm64: dts: qcom: ipq5018: Add USB related nodes
On 8/31/2023 1:13 AM, Dmitry Baryshkov wrote:
> On Wed, 30 Aug 2023 at 21:30, Nitheesh Sekar <quic_nsekar@...cinc.com> wrote:
>> Add USB phy and controller nodes.
>>
>> Co-developed-by: Amandeep Singh <quic_amansing@...cinc.com>
>> Signed-off-by: Amandeep Singh <quic_amansing@...cinc.com>
>> Signed-off-by: Nitheesh Sekar <quic_nsekar@...cinc.com>
>> ---
>> V2:
>> Fix ordering of the USB related nodes and use
>> generic node names.
>> ---
>> arch/arm64/boot/dts/qcom/ipq5018.dtsi | 54 +++++++++++++++++++++++++++
>> 1 file changed, 54 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
>> index 9f13d2dcdfd5..917e4a2d8e64 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
>> @@ -93,6 +93,19 @@
>> #size-cells = <1>;
>> ranges = <0 0 0 0xffffffff>;
>>
>> + usbphy0: phy@...00 {
>> + compatible = "qcom,ipq5018-usb-hsphy";
>> + reg = <0x0005b000 0x120>;
>> +
>> + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>;
>> +
>> + resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
>> +
>> + #phy-cells = <0>;
>> +
>> + status = "disabled";
>> + };
>> +
>> tlmm: pinctrl@...0000 {
>> compatible = "qcom,ipq5018-tlmm";
>> reg = <0x01000000 0x300000>;
>> @@ -155,6 +168,47 @@
>> status = "disabled";
>> };
>>
>> + usb: usb@...8800 {
>> + compatible = "qcom,ipq5018-dwc3", "qcom,dwc3";
>> + reg = <0x08af8800 0x400>;
>> +
>> + interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "hs_phy_irq";
>> +
>> + clocks = <&gcc GCC_USB0_MASTER_CLK>,
>> + <&gcc GCC_SYS_NOC_USB0_AXI_CLK>,
>> + <&gcc GCC_USB0_SLEEP_CLK>,
>> + <&gcc GCC_USB0_MOCK_UTMI_CLK>;
>> + clock-names = "core",
>> + "iface",
>> + "sleep",
>> + "mock_utmi";
>> +
>> + resets = <&gcc GCC_USB0_BCR>;
>> +
>> + qcom,select-utmi-as-pipe-clk;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
>> +
>> + status = "disabled";
>> +
>> + usb2_0_dwc: usb@...0000 {
> As we have seen from the next patchset, this host supports USB 3.0.
> Can you please drop the 2_0 part of the label?
Sure. Will drop "2_0".
Regards,
Nitheesh
Powered by blists - more mailing lists