linux-kernel - Re: [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Sep 2023 09:10:25 +0300
From:   Alexandru Ardelean <alex@...uggie.ro>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        herbert@...dor.apana.org.au, olivia@...enic.com
Subject: Re: [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set_drvdata()

On Fri, Sep 1, 2023 at 9:04 AM Alexandru Ardelean <alex@...uggie.ro> wrote:
>
> On Mon, Aug 28, 2023 at 1:29 PM Andrei Coardos <aboutphysycs@...il.com> wrote:
> >
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver. Also,
> > the private data is defined in this driver, so there is no risk of it being
> > accessed outside of this driver file.
> >
> > Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> > ---
> >  drivers/char/hw_random/xiphera-trng.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/char/hw_random/xiphera-trng.c b/drivers/char/hw_random/xiphera-trng.c
> > index 2a9fea72b2e0..1fa4b70246f0 100644
> > --- a/drivers/char/hw_random/xiphera-trng.c
> > +++ b/drivers/char/hw_random/xiphera-trng.c
> > @@ -122,8 +122,6 @@ static int xiphera_trng_probe(struct platform_device *pdev)
> >                 return ret;
> >         }
> >
> > -       platform_set_drvdata(pdev, trng);
> > -
> >         return 0;
>
> This entire block could become now:
>
>         return devm_hwrng_register(dev, &trng->rng);
>

Coming back here.
I wonder if there is a desire to keep the prints above.
If yes, then this is fine as-is.
With that:

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>

> >  }
> >
> > --
> > 2.34.1
> >