linux-kernel - Re: [PATCH v2] clk: qcom: ipq5332: Drop set rate parent from gpll0 dependent clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3469c64-f7e7-259a-ebcf-8879dcfb33a0@quicinc.com>
Date:   Fri, 1 Sep 2023 13:11:33 +0530
From:   Kathiravan T <quic_kathirav@...cinc.com>
To:     Varadarajan Narayanan <quic_varada@...cinc.com>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <mturquette@...libre.com>,
        <sboyd@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] clk: qcom: ipq5332: Drop set rate parent from gpll0
 dependent clocks


On 8/31/2023 2:58 PM, Varadarajan Narayanan wrote:
> IPQ5332's GPLL0's nominal/turbo frequency is 800MHz.
> This must not be scaled based on the requirement of
> dependent clocks. Hence remove the CLK_SET_RATE_PARENT
> flag.


Reviewed-by: Kathiravan T <quic_kathirav@...cinc.com>


>
> Fixes: 3d89d52970fd ("clk: qcom: add Global Clock controller (GCC) driver for IPQ5332 SoC")
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
>   drivers/clk/qcom/gcc-ipq5332.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq5332.c
> index b02026f..b836159 100644
> --- a/drivers/clk/qcom/gcc-ipq5332.c
> +++ b/drivers/clk/qcom/gcc-ipq5332.c
> @@ -71,7 +71,6 @@ static struct clk_fixed_factor gpll0_div2 = {
>   				&gpll0_main.clkr.hw },
>   		.num_parents = 1,
>   		.ops = &clk_fixed_factor_ops,
> -		.flags = CLK_SET_RATE_PARENT,
>   	},
>   };
>   
> @@ -85,7 +84,6 @@ static struct clk_alpha_pll_postdiv gpll0 = {
>   				&gpll0_main.clkr.hw },
>   		.num_parents = 1,
>   		.ops = &clk_alpha_pll_postdiv_ro_ops,
> -		.flags = CLK_SET_RATE_PARENT,
>   	},
>   };
>