linux-kernel - Re: [PATCH v3 3/3] platform/mellanox: mlxbf-pmc: Add support for BlueField-3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1cff33c7-176f-4da7-98cd-bacea1b09b@linux.intel.com>
Date:   Fri, 1 Sep 2023 13:50:00 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Shravan Kumar Ramani <shravankr@...dia.com>
cc:     Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Vadim Pasternak <vadimp@...dia.com>,
        David Thompson <davthompson@...dia.com>,
        platform-driver-x86@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/3] platform/mellanox: mlxbf-pmc: Add support for
 BlueField-3

On Fri, 1 Sep 2023, Shravan Kumar Ramani wrote:

> Add new access mechanism and list of supported events to program
> and read the counters in BlueField-3.
> Performance counter blocks being added for BlueField-3 include:
>   - Memory Sub-system (mss) which has counters for monitoring
> various DRAM and related skylib events
>   - Last level Tile, which has 2 sets of counters (llt, llt_miss)
> for monitoring Tile and cache metrics
> 
> Signed-off-by: Shravan Kumar Ramani <shravankr@...dia.com>
> Reviewed-by: Vadim Pasternak <vadimp@...dia.com>
> Reviewed-by: David Thompson <davthompson@...dia.com>
> ---
>  drivers/platform/mellanox/mlxbf-pmc.c | 685 ++++++++++++++++++++++++--
>  1 file changed, 653 insertions(+), 32 deletions(-)

> -	ret = device_property_read_u32(dev, "tile_num", &pmc->tile_count);
> -	if (ret)
> -		return ret;
> +	if (device_property_read_u32(dev, "tile_num", &pmc->tile_count)) {
> +		if (device_property_read_u8(dev, "llt_enable",
> +					    &pmc->llt_enable)) {

Just put this into a single line.

> +			dev_err(dev, "Number of tiles/LLTs undefined\n");
> +			return -EINVAL;
> +		}
> +		if (device_property_read_u8(dev, "mss_enable",
> +					    &pmc->mss_enable)) {

Ditto.

-- 
 i.