linux-kernel - Re: [PATCH] tracing: zero the pipe cpumask on alloc to avoid spurious -EBUSY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <27b90c36-7552-6e6c-4109-3220c90ce83e@huawei.com>
Date:   Fri, 1 Sep 2023 09:34:16 +0800
From:   Zheng Yejian <zhengyejian1@...wei.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     Brian Foster <bfoster@...hat.com>,
        <linux-trace-kernel@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: zero the pipe cpumask on alloc to avoid spurious
 -EBUSY

On 2023/9/1 04:33, Steven Rostedt wrote:
> On Thu, 31 Aug 2023 21:51:18 +0800
> Zheng Yejian <zhengyejian1@...wei.com> wrote:
> 
>>> Hi,
>>>
>>> I ran into this problem just recently on one of my test VMs immediately
>>> after updating to a v6.5 base. A revert of the aforementioned commit
>>> addressed the problem. I'm not terribly familiar with the tracing code,
>>> but on further inspection I noticed the cpumask doesn't appear to be
>>> initialized anywhere. I suppose this could alternatively do a
>>> cpumask_clear() or whatever after allocation, but either way this
>>> addresses the problem for me.
>>
>> Yes, pipe_cpumask must be initialized.
> 
> Can I add a Reviewed-by tag from you?

Of course :)
Reviewed-by: Zheng Yejian <zhengyejian1@...wei.com>

--

Thanks,
Zheng Yejian

> 
>>
>>>
>>> Please CC on replies as I'm not subscribed to the list. Thanks.
> 
> That's the default with Linux kernel lists.
> 
> -- Steve
>