linux-kernel - Re: [PATCH] mmc: host: Kconfig: Allow selecting MMC_SDHI_INTERNAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8t348RAYu8ApmW-3WpPY_qmHKPX3=+Pc-y=n2nZ7DEocg@mail.gmail.com>
Date:   Fri, 1 Sep 2023 12:48:20 +0100
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Biju Das <biju.das.jz@...renesas.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH] mmc: host: Kconfig: Allow selecting MMC_SDHI_INTERNAL_DMAC
 for RZ/Five SoC

Hi Geert,

Thank you for the review.

On Fri, Sep 1, 2023 at 12:40 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Fri, Sep 1, 2023 at 1:37 PM Prabhakar <prabhakar.csengg@...il.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Make MMC_SDHI_INTERNAL_DMAC visible for RISC-V architecture so that we can
> > select this config option for RZ/Five SoC which is based on RISC-V
> > architecture.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Thanks for your patch!
>
> > I was in two minds here whether I should instead add dependency for
> > ARCH_R9A07G043 instead of RISCV. But adding dependency for RISCV allows
> > us to get this config option freely for future coming RISC-V Renesas
> > SoCs.
> >
> > Cheers, Prabhakar
> > ---
> >  drivers/mmc/host/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 554e67103c1a..5190881cb204 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -677,9 +677,9 @@ config MMC_SDHI_SYS_DMAC
> >
> >  config MMC_SDHI_INTERNAL_DMAC
> >         tristate "DMA for SDHI SD/SDIO controllers using on-chip bus mastering"
> > -       depends on ARM64 || ARCH_R7S9210 || ARCH_R8A77470 || COMPILE_TEST
> > +       depends on ARM64 || ARCH_R7S9210 || ARCH_R8A77470 || RISCV || COMPILE_TEST
> >         depends on MMC_SDHI
> > -       default MMC_SDHI if (ARM64 || ARCH_R7S9210 || ARCH_R8A77470)
> > +       default MMC_SDHI if (ARM64 || ARCH_R7S9210 || ARCH_R8A77470 || RISCV)
>
> This would expose this option to a growing number of non-Renesas
> RISC-V platforms.  What about using ARCH_RENESAS || COMPILE_TEST
> instead?
>
Good point. I'll make the changes as per below:

--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -677,9 +677,9 @@ config MMC_SDHI_SYS_DMAC

 config MMC_SDHI_INTERNAL_DMAC
        tristate "DMA for SDHI SD/SDIO controllers using on-chip bus mastering"
-       depends on ARM64 || ARCH_R7S9210 || ARCH_R8A77470 || COMPILE_TEST
+       depends on ARCH_RENESAS || COMPILE_TEST
        depends on MMC_SDHI
-       default MMC_SDHI if (ARM64 || ARCH_R7S9210 || ARCH_R8A77470)
+       default MMC_SDHI if ARCH_RENESAS
        help
          This provides DMA support for SDHI SD/SDIO controllers
          using on-chip bus mastering. This supports the controllers

Cheers,
Prabhakar

> >         help
> >           This provides DMA support for SDHI SD/SDIO controllers
> >           using on-chip bus mastering. This supports the controllers
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds