linux-kernel - Re: [RFT PATCH v2] spi: bcm2835: reduce the abuse of the GPIO API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d57a99ce-77eb-409f-8371-95f2658fa0c0@sirena.org.uk>
Date:   Fri, 1 Sep 2023 13:57:54 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>, linux-spi@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [RFT PATCH v2] spi: bcm2835: reduce the abuse of the GPIO API

On Fri, Sep 01, 2023 at 02:33:03PM +0200, Bartosz Golaszewski wrote:
> On Fri, Sep 1, 2023 at 2:31 PM Mark Brown <broonie@...nel.org> wrote:
> > On Fri, Sep 01, 2023 at 02:15:39PM +0200, Linus Walleij wrote:
> > > On Fri, Sep 1, 2023 at 1:15 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:

> > > > +       struct gpiod_lookup_table *lookup __free(kfree) = NULL;

> > > This is really neat.
> > > As noted, it will confuse static checkers at no end, but they just have
> > > to adopt. (CC to Dan C if he now runs into this.)

> > It also doesn't look amazing for humans, it's very not C like...

> Once it's widely adopted, you'll see how much clearer and less prone
> to bugs in error paths the code becomes with autopointers. It's 2023
> dammit, if we can't have flying cars, let's at least get some RAII
> into the kernel. :)

I use RAII extensively with other languages, I also know that with C you
have to be careful and look to make sure everything is freed.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)