linux-kernel - Re: [PATCH v2] arm64: dts: ipq5018: Correct uart1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90a3675c-2e30-35a5-85d9-3d1b895ab265@linaro.org>
Date:   Fri, 1 Sep 2023 15:31:41 +0100
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Ziyang Huang <hzyitc@...look.com>
Cc:     agross@...nel.org, andersson@...nel.org, conor+dt@...nel.org,
        devicetree@...r.kernel.org, konrad.dybcio@...aro.org,
        krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_gokulsri@...cinc.com,
        quic_srichara@...cinc.com, quic_varada@...cinc.com,
        robh+dt@...nel.org
Subject: Re: [PATCH v2] arm64: dts: ipq5018: Correct uart1_pins pinconf

On 01/09/2023 14:09, Ziyang Huang wrote:
>> Is this change something that should be expressed for a particular 
>> board ?
>>
> 
> Yes, this is device-special. Some boards use GPIO20 and 21 while others 
> use GPIO28 and 29. But we have defined a wrong value here. At lease, it 
> should be a correct demo. Or should I leave 2 configs here to let device 
> choose?

https://gist.github.com/ptpt52/ae47eb7b86ce2911df06d067152f02ac

U-Boot 2016.01 (Jul 08 2021 - 07:14:42 +0000)

DRAM:  smem ram ptable found: ver: 1 len: 4
256 MiB
TEST-
SPI_ADDR_LEN=3
SF: Detected XM25QU128C with page size 256 Bytes, erase size 4 KiB, 
total 16 MiB
*** Warning - bad CRC, using default environment

In:    serial@...F000
Out:   serial@...F000
Err:   serial@...F000

So, we're saying the correct default console is blsp0_uart0 ?

https://git.codelinaro.org/clo/qsdk/oss/boot/u-boot-2016/-/blob/5343739b4070bcec2fecd72f758c16adc31a3083/arch/arm/dts/ipq5018-mp03.3.dts

---
bod