linux-kernel - Re: [PATCH 1/3] dt-bindings: power: syscon-poweroff: get regmap from parent node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230901-uninvited-crewless-a2146c901e2d@spud>
Date:   Fri, 1 Sep 2023 16:57:17 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: power: syscon-poweroff: get regmap from
 parent node

Yo,

Two minor nits that look like copy-paste duplication of the same
problems in the syscon-reboot binding.

On Fri, Sep 01, 2023 at 02:00:55PM +0200, Krzysztof Kozlowski wrote:
> Just like syscon-reboot device, the syscon-poweroff is supposed to be a
> child of syscon node, thus we can take the same approach as
> syscon-poweroff: deprecate the 'regmap' field in favor of taking it from
> the parent's node.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> See also syscon-regmap:
> https://lore.kernel.org/all/20200526135102.21236-1-Sergey.Semin@baikalelectronics.ru/
> ---
>  .../bindings/power/reset/syscon-poweroff.yaml          | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> index 3412fe7e1e80..3c58f8251882 100644
> --- a/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/syscon-poweroff.yaml
> @@ -15,6 +15,9 @@ description: |+
>    defined by the register map pointed by syscon reference plus the offset
>    with the value and mask defined in the poweroff node.
>    Default will be little endian mode, 32 bit access only.
> +  The SYSCON registers map is normally retrieved from the parental dt-node. So

s/registers/register/, no?

> +  the SYSCON poweroff node should be represented as a sub-node of a "syscon",
> +  "simple-mfd" node.
>  
>  properties:
>    compatible:
> @@ -30,7 +33,10 @@ properties:
>  
>    regmap:
>      $ref: /schemas/types.yaml#/definitions/phandle
> -    description: Phandle to the register map node.
> +    deprecated: true
> +    description:
> +      Phandle to the register map node. This property is deprecated in favor of
> +      the syscon-poweroff node been a child of a system controller node.

s/been/being/

Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

>  
>    value:
>      $ref: /schemas/types.yaml#/definitions/uint32
> @@ -38,7 +44,6 @@ properties:
>  
>  required:
>    - compatible
> -  - regmap
>    - offset
>  
>  additionalProperties: false
> @@ -56,7 +61,6 @@ examples:
>    - |
>      poweroff {
>          compatible = "syscon-poweroff";
> -        regmap = <&regmapnode>;
>          offset = <0x0>;
>          mask = <0x7a>;
>      };
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)