linux-kernel - Re: [PATCH v3] HID: i2c-hid: use print_hex_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pm31vq8u.fsf@protonmail.com>
Date:   Fri, 01 Sep 2023 15:59:37 +0000
From:   Rahul Rameshbabu <sergeantsagara@...tonmail.com>
To:     Riwen Lu <luriwen@...mail.com>
Cc:     jikos@...nel.org, benjamin.tissoires@...hat.com,
        dmitry.torokhov@...il.com, linux@...ssschuh.net,
        hdegoede@...hat.com, rrangel@...omium.org,
        u.kleine-koenig@...gutronix.de, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, Riwen Lu <luriwen@...inos.cn>
Subject: Re: [PATCH v3] HID: i2c-hid: use print_hex_dump_debug to print report descriptor


On Fri, 01 Sep, 2023 16:33:56 +0800 "Riwen Lu" <luriwen@...mail.com> wrote:
> From: Riwen Lu <luriwen@...inos.cn>
>
> The format '%*ph' prints up to 64 bytes long as a hex string with ' '
> separator. Usually the size of report descriptor is larger than 64
> bytes, so consider using print_hex_dump_debug to print out all of it for
> better debugging.
>
> Signed-off-by: Riwen Lu <luriwen@...inos.cn>
>
> ---
> v1->v2:
>  - Add a prefix for the hex dump.
>
> v2->v3:
>  - Print the size of report descriptor.
> ---
>  drivers/hid/i2c-hid/i2c-hid-core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index efbba0465eef..dd69abdd1f0d 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -772,7 +772,9 @@ static int i2c_hid_parse(struct hid_device *hid)
>  		}
>  	}
>
> -	i2c_hid_dbg(ihid, "Report Descriptor: %*ph\n", rsize, rdesc);
> +	i2c_hid_dbg(ihid, "Report Descriptor size: %#x\n", rsize);
> +	print_hex_dump_debug("Report Descriptor: ", DUMP_PREFIX_OFFSET, 16, 1,
> +			rdesc, rsize, false);
>
>  	ret = hid_parse_report(hid, rdesc, rsize);
>  	if (!use_override)

Thanks for the new version.

Reviewed-by: Rahul Rameshbabu <sergeantsagara@...tonmail.com>