linux-kernel - RE: [PATCH v2 3/5] mm: Add structure to keep sva information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW5PR11MB58812C6D52210A9A66A79C1689E4A@MW5PR11MB5881.namprd11.prod.outlook.com>
Date:   Fri, 1 Sep 2023 03:36:44 +0000
From:   "Zhang, Tina" <tina.zhang@...el.com>
To:     Baolu Lu <baolu.lu@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "Tian, Kevin" <kevin.tian@...el.com>,
        Michael Shavit <mshavit@...gle.com>
CC:     "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 3/5] mm: Add structure to keep sva information

Hi Baolu,

> -----Original Message-----
> From: Baolu Lu <baolu.lu@...ux.intel.com>
> Sent: Thursday, August 31, 2023 10:45 AM
> To: Zhang, Tina <tina.zhang@...el.com>; Jason Gunthorpe <jgg@...pe.ca>;
> Tian, Kevin <kevin.tian@...el.com>; Michael Shavit <mshavit@...gle.com>
> Cc: baolu.lu@...ux.intel.com; iommu@...ts.linux.dev; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v2 3/5] mm: Add structure to keep sva information
> 
> On 2023/8/27 16:43, Tina Zhang wrote:
> > Introduce iommu_mm_data structure to keep sva information (pasid and
> > the related sva domains). Add iommu_mm pointer, pointing to an
> > instance of iommu_mm_data structure, to mm.
> >
> > Signed-off-by: Tina Zhang<tina.zhang@...el.com>
> > ---
> >   include/linux/iommu.h    | 5 +++++
> >   include/linux/mm_types.h | 2 ++
> >   2 files changed, 7 insertions(+)
> 
> Nit:
> 
> iommu also has a per-device private pointer, it's defined as struct dev_iommu
> and stored at dev->iommu. Is it valuable to align both?
I'm not sure if I understand the idea correctly. This struct dev_iommu is used to describe a collection per-device IOMMU data. Is the idea about migrating some bits from this struct dev_iommu to iommu_mm_data structure?

Thanks,
-Tina
> 
> Best regards,
> baolu