linux-kernel - Re: [PATCH v2] ata: Disable NCQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Sep 2023 18:51:52 +0000
From:   Niklas Cassel <Niklas.Cassel@....com>
To:     Pawel Zmarzly <pzmarzly@...a.com>
CC:     Damien Le Moal <dlemoal@...nel.org>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ata: Disable NCQ_TRIM on Micron 1100 drives

Hello Pawel,

On Fri, Sep 01, 2023 at 11:23:17AM -0700, Pawel Zmarzly wrote:
> Micron 1100 drives lock up when encountering queued TRIM command.
> It is a quite old hardware series, for past years we have been
> running our machines with these drives using
> libata.force=noncqtrim.
> ---
> V1 -> V2: Fixed formatting.
> ---
>  drivers/ata/libata-core.c | 2 ++
>  1 file changed, 2 insertions(+)

I think you forgot your Signed-off-by tag this time.

See:
https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format

E.g.

<commit message>
...
Signed-off-by: Author <author@...l>
---
V2 -> V3: Removed redundant helper function
V1 -> V2: Cleaned up coding style and addressed review comments

path/to/file | 5+++--
...


If you run ./scripts/checkpatch.pl against your patch,
it should tell you if the Signed-off-by tag is missing.


Kind regards,
Niklas