[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <10acb196-b7e4-1b19-6015-c44e72bea1cc@ti.com>
Date: Sat, 2 Sep 2023 05:44:51 -0500
From: Hari Nagalla <hnagalla@...com>
To: Mathieu Poirier <mathieu.poirier@...aro.org>
CC: <andersson@...nel.org>, <p.zabel@...gutronix.de>,
<martyn.welch@...labora.com>, <nm@...com>, <vigneshr@...com>,
<kristo@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<devicetree@...r.kernel.org>
Subject: Re: [PATCH v5 4/5] remoteproc: k3: Split out functions common with M4
driver
Hi Mathieu,
On 8/29/23 14:47, Mathieu Poirier wrote:
>> Signed-off-by: Martyn Welch<martyn.welch@...labora.com>
>> Signed-off-by: Hari Nagalla<hnagalla@...com>
>> ---
>> Changes since v2:
>> - New patch (reordered refactored from v2)
>>
>> Changes since v3:
>> - Removed "ipc_only" element from k3_rproc structure
>> - Refactored to bring 3 more common functions
>>
>> Changes since v4:
>> - None
>>
>> drivers/remoteproc/Makefile | 2 +-
>> drivers/remoteproc/ti_k3_common.c | 513 +++++++++++++++++++
>> drivers/remoteproc/ti_k3_common.h | 103 ++++
>> drivers/remoteproc/ti_k3_dsp_remoteproc.c | 598 ++--------------------
>> 4 files changed, 646 insertions(+), 570 deletions(-)
>> create mode 100644 drivers/remoteproc/ti_k3_common.c
>> create mode 100644 drivers/remoteproc/ti_k3_common.h
> This patch is hard to follow because of all the things it does. Please do the
> structures in one patch and the functions in another.
>
I will re-structure the patches as you suggested for driver and also
separate the device tree node patches to avoid clutter.
Thanks
Powered by blists - more mailing lists