linux-kernel - Re: mainline build failure due to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVatmMF1QS235CD4KbDPy_w9hAi0rN1EJqAXtJok2Xg0iE-UA@mail.gmail.com>
Date:   Sat, 2 Sep 2023 12:09:59 +0100
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Thomas Zimmermann <tzimmermann@...e.de>,
        Helge Deller <deller@....de>, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        regressions@...ts.linux.dev
Subject: Re: mainline build failure due to 501126083855 ("fbdev/g364fb: Use
 fbdev I/O helpers")

On Thu, 31 Aug 2023 at 20:04, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Thu, 31 Aug 2023 at 11:48, Sudip Mukherjee (Codethink)
> <sudipm.mukherjee@...il.com> wrote:
> > The latest mainline kernel branch fails to build mips jazz_defconfig with
> > the error:
> >
> > drivers/video/fbdev/g364fb.c:115:9: error: 'FB_DEFAULT_IOMEM_HELPERS' undeclared here (not in a function); did you mean 'FB_DEFAULT_IOMEM_OPS'?
> >   115 |         FB_DEFAULT_IOMEM_HELPERS,
> >       |         ^~~~~~~~~~~~~~~~~~~~~~~~
> >       |         FB_DEFAULT_IOMEM_OPS
> >
> >
> > git bisect pointed to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers").
> >
> > Reverting the commit has fixed the build failure.
> >
> > I will be happy to test any patch or provide any extra log if needed.
>
> Would you mind testing the exact thing that the compiler suggested?
>
> So instead of the revert, just replace FB_DEFAULT_IOMEM_HELPERS with
> FB_DEFAULT_IOMEM_OPS.
>
> I think it's just a typo / confusion with the config variable (which
> is called FB_IOMEM_HELPERS).

Yeah, you were right.
Patch sent - https://lore.kernel.org/lkml/20230902095102.5908-1-sudip.mukherjee@codethink.co.uk/


-- 
Regards
Sudip