linux-kernel - Re: [PATCH v2] media: i2c: imx334: add support for test pattern generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8104a9b8f238231a10e7ea4f7079363d88d665b5.camel@intel.com>
Date:   Sat, 2 Sep 2023 13:22:24 +0000
From:   "Alessandrelli, Daniele" <daniele.alessandrelli@...el.com>
To:     "Murphy, Paul J" <paul.j.murphy@...el.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "shravan.chippa@...rochip.com" <shravan.chippa@...rochip.com>
CC:     "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "sakari.ailus@....fi" <sakari.ailus@....fi>
Subject: Re: [PATCH v2] media: i2c: imx334: add support for test pattern
 generator

On Fri, 2023-08-04 at 20:45 +0530, shravan kumar wrote:
> From: Shravan Chippa <shravan.chippa@...rochip.com>
> 
> Add support for the imx334's test pattern generator.
> By default the test pattern generator is disabled, so add support for
> enabling and disabling horizontal and vertical colour bars.
> 
> Signed-off-by: Shravan Chippa <shravan.chippa@...rochip.com>
> ---
>  drivers/media/i2c/imx334.c | 57 +++++++++++++++++++++++++++++++++++++-
>  1 file changed, 56 insertions(+), 1 deletion(-)

Acked-by: Daniele Alessandrelli <daniele.alessandrelli@...el.com>

> 
> diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
> index d722c9b7cd31..91c79af70734 100644
> --- a/drivers/media/i2c/imx334.c
> +++ b/drivers/media/i2c/imx334.c
> @@ -56,6 +56,24 @@
>  #define IMX334_REG_MIN         0x00
>  #define IMX334_REG_MAX         0xfffff
>  
> +/* Test Pattern Control */
> +#define IMX334_REG_TP          0x329e
> +#define IMX334_TP_COLOR_HBARS  0xA
> +#define IMX334_TP_COLOR_VBARS  0xB
> +
> +#define IMX334_TPG_EN_DOUT     0x329c
> +#define IMX334_TP_ENABLE       0x1
> +#define IMX334_TP_DISABLE      0x0
> +
> +#define IMX334_TPG_COLORW      0x32a0
> +#define IMX334_TPG_COLORW_120P 0x13
> +
> +#define IMX334_TP_CLK_EN       0x3148
> +#define IMX334_TP_CLK_EN_VAL   0x10
> +#define IMX334_TP_CLK_DIS_VAL  0x0
> +
> +#define IMX334_DIG_CLP_MODE    0x3280
> +
>  /**
>   * struct imx334_reg - imx334 sensor register
>   * @address: Register address
> @@ -430,6 +448,18 @@ static const struct imx334_reg mode_3840x2160_regs[] = {
>         {0x3a29, 0x00},
>  };
>  
> +static const char * const imx334_test_pattern_menu[] = {
> +       "Disabled",
> +       "Vertical Color Bars",
> +       "Horizontal Color Bars",
> +};
> +
> +static const int imx334_test_pattern_val[] = {
> +       IMX334_TP_DISABLE,
> +       IMX334_TP_COLOR_HBARS,
> +       IMX334_TP_COLOR_VBARS,
> +};
> +
>  static const struct imx334_reg raw10_framefmt_regs[] = {
>         {0x3050, 0x00},
>         {0x319d, 0x00},
> @@ -716,6 +746,26 @@ static int imx334_set_ctrl(struct v4l2_ctrl *ctrl)
>         case V4L2_CID_HBLANK:
>                 ret = 0;
>                 break;
> +       case V4L2_CID_TEST_PATTERN:
> +               if (ctrl->val) {
> +                       imx334_write_reg(imx334, IMX334_TP_CLK_EN, 1,
> +                                        IMX334_TP_CLK_EN_VAL);
> +                       imx334_write_reg(imx334, IMX334_DIG_CLP_MODE, 1, 0x0);
> +                       imx334_write_reg(imx334, IMX334_TPG_COLORW, 1,
> +                                        IMX334_TPG_COLORW_120P);
> +                       imx334_write_reg(imx334, IMX334_REG_TP, 1,
> +                                        imx334_test_pattern_val[ctrl->val]);
> +                       imx334_write_reg(imx334, IMX334_TPG_EN_DOUT, 1,
> +                                        IMX334_TP_ENABLE);
> +               } else {
> +                       imx334_write_reg(imx334, IMX334_DIG_CLP_MODE, 1, 0x1);
> +                       imx334_write_reg(imx334, IMX334_TP_CLK_EN, 1,
> +                                        IMX334_TP_CLK_DIS_VAL);
> +                       imx334_write_reg(imx334, IMX334_TPG_EN_DOUT, 1,
> +                                        IMX334_TP_DISABLE);
> +               }
> +               ret = 0;
> +               break;
>         default:
>                 dev_err(imx334->dev, "Invalid control %d", ctrl->id);
>                 ret = -EINVAL;
> @@ -1222,7 +1272,7 @@ static int imx334_init_controls(struct imx334 *imx334)
>         u32 lpfr;
>         int ret;
>  
> -       ret = v4l2_ctrl_handler_init(ctrl_hdlr, 6);
> +       ret = v4l2_ctrl_handler_init(ctrl_hdlr, 7);
>         if (ret)
>                 return ret;
>  
> @@ -1282,6 +1332,11 @@ static int imx334_init_controls(struct imx334 *imx334)
>         if (imx334->hblank_ctrl)
>                 imx334->hblank_ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;
>  
> +       v4l2_ctrl_new_std_menu_items(ctrl_hdlr, &imx334_ctrl_ops,
> +                                    V4L2_CID_TEST_PATTERN,
> +                                    ARRAY_SIZE(imx334_test_pattern_menu) - 1,
> +                                    0, 0, imx334_test_pattern_menu);
> +
>         if (ctrl_hdlr->error) {
>                 dev_err(imx334->dev, "control init failed: %d",
>                         ctrl_hdlr->error);