linux-kernel - Re: [PATCH 0/7] perf: strcmp_cpuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fVrF34FYUZ=vKHPVUbkTiCTBnmQuZVyeS2JWGBjS_eerw@mail.gmail.com>
Date:   Fri, 1 Sep 2023 19:53:10 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     James Clark <james.clark@....com>
Cc:     linux-perf-users@...r.kernel.org,
        John Garry <john.g.garry@...cle.com>,
        Will Deacon <will@...nel.org>,
        Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Haixin Yu <yuhaixin.yhx@...ux.alibaba.com>,
        Jing Zhang <renyu.zj@...ux.alibaba.com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        Ravi Bangoria <ravi.bangoria@....com>,
        Yang Jihong <yangjihong1@...wei.com>,
        Eduard Zingerman <eddyz87@...il.com>,
        Chen Zhongjin <chenzhongjin@...wei.com>,
        Miguel Ojeda <ojeda@...nel.org>,
        Liam Howlett <liam.howlett@...cle.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/7] perf: strcmp_cpuid_str() expression fixups

On Thu, Aug 31, 2023 at 8:16 AM James Clark <james.clark@....com> wrote:
>
> Set of fixes related to the comments here [1]. Mainly cleanups,
> additional tests and refactoring since adding the new strcmp_cpuid_str()
> metric expression.
>
> I added the string replace function to the perf utils
> rather than tools/lib/string.c because it didn't seem
> easy to add tests for tools/lib.
>
> [1]: https://lore.kernel.org/linux-arm-kernel/CAP-5=fVnUx0BnJC7X1rrm42OD7Bk=ZsHWNwAZMBYyB7yWhBfhQ@mail.gmail.com/
>
> James Clark (7):
>   perf test: Check result of has_event(cycles) test
>   perf jevents: Remove unused keyword
>   perf util: Add a function for replacing characters in a string
>   perf test: Add a test for strcmp_cpuid_str() expression
>   perf pmu: Move pmu__find_core_pmu() to pmus.c
>   perf pmus: Simplify perf_pmus__find_core_pmu()
>   perf pmu: Remove unused function

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

>  tools/perf/arch/arm64/util/pmu.c | 20 ++++++-------
>  tools/perf/pmu-events/metric.py  |  3 +-
>  tools/perf/tests/Build           |  1 +
>  tools/perf/tests/builtin-test.c  |  1 +
>  tools/perf/tests/expr.c          | 33 ++++++++++++++++++----
>  tools/perf/tests/tests.h         |  1 +
>  tools/perf/tests/util.c          | 30 ++++++++++++++++++++
>  tools/perf/util/expr.c           |  2 +-
>  tools/perf/util/pmu.c            | 22 ---------------
>  tools/perf/util/pmu.h            |  3 +-
>  tools/perf/util/pmus.c           |  6 ++++
>  tools/perf/util/string.c         | 48 ++++++++++++++++++++++++++++++++
>  tools/perf/util/string2.h        |  1 +
>  13 files changed, 127 insertions(+), 44 deletions(-)
>  create mode 100644 tools/perf/tests/util.c
>
> --
> 2.34.1
>