linux-kernel - Re: [PATCH v3] ata: Disable NCQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 2 Sep 2023 12:11:23 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Pawel Zmarzly <pzmarzly@...a.com>, Niklas.Cassel@....com
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ata: Disable NCQ_TRIM on Micron 1100 drives

On 9/2/23 11:54, Damien Le Moal wrote:
> On 9/2/23 05:02, Pawel Zmarzly wrote:
>> Micron 1100 drives lock up when encountering queued TRIM command.
>> It is a quite old hardware series, for past years we have been
>> running our machines with these drives using
>> libata.force=noncqtrim.
>>
>> Signed-off-by: Pawel Zmarzly <pzmarzly@...a.com>
> 
> This does not apply cleanly on the fo-6.6 branch. Can you rebase your patch
> please and make sure it applies to libata tree for-6.6 branch ?

Don't bother. I applied the patch manually with some minor tweaks.
It is now queued for 6.6. Thanks.

> 
>> ---
>> V1 -> V2: Fixed formatting.
>> V2 -> V3: Added missing Signed off line. Sorry, this is my
>> first time upstreaming.
>>
>>  drivers/ata/libata-core.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>> index 175b2a9dc000..116f5fd6e3f7 100644
>> --- a/drivers/ata/libata-core.c
>> +++ b/drivers/ata/libata-core.c
>> @@ -4564,6 +4564,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>>  						ATA_HORKAGE_ZERO_AFTER_TRIM, },
>>  	{ "FCCT*M500*",			NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
>>  						ATA_HORKAGE_ZERO_AFTER_TRIM, },
>> +	{ "Micron_1100_*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
>> +						ATA_HORKAGE_ZERO_AFTER_TRIM, },
>>
>>  	/* devices that don't properly handle TRIM commands */
>>  	{ "SuperSSpeed S238*",		NULL,	ATA_HORKAGE_NOTRIM, },
>> --
>> 2.39.3
> 

-- 
Damien Le Moal
Western Digital Research