linux-kernel - Re: [PATCH 2/2] ARM: dts: qcom: msm8226: Add blsp1_i2c6 and blsp1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11f4e8f9-1193-4c6a-a5ae-cf592039a6b9@linaro.org>
Date:   Sat, 2 Sep 2023 22:33:11 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Luca Weiss <luca@...tu.xyz>, ~postmarketos/upstreaming@...ts.sr.ht,
        phone-devel@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: msm8226: Add blsp1_i2c6 and
 blsp1_uart2

On 2.09.2023 19:32, Luca Weiss wrote:
> Add more busses found on msm8226 SoC.
> 
> Signed-off-by: Luca Weiss <luca@...tu.xyz>
> ---
>  arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> index b6ae4b7936e3..3b6114049e61 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi
> @@ -230,6 +230,15 @@ blsp1_uart1: serial@...1d000 {
>  			status = "disabled";
>  		};
>  
> +		blsp1_uart2: serial@...1e000 {
> +			compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
> +			reg = <0xf991e000 0x1000>;
> +			interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&gcc GCC_BLSP1_UART2_APPS_CLK>, <&gcc GCC_BLSP1_AHB_CLK>;
One per line, please
> +			clock-names = "core", "iface";
> +			status = "disabled";
> +		};
> +
>  		blsp1_uart3: serial@...1f000 {
>  			compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
>  			reg = <0xf991f000 0x1000>;
> @@ -313,6 +322,19 @@ blsp1_i2c5: i2c@...27000 {
>  			#size-cells = <0>;
>  		};
>  
> +		blsp1_i2c6: i2c@...28000 {
> +			status = "disabled";
> +			compatible = "qcom,i2c-qup-v2.1.1";
> +			reg = <0xf9928000 0x1000>;
> +			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&gcc GCC_BLSP1_QUP6_I2C_APPS_CLK>, <&gcc GCC_BLSP1_AHB_CLK>;
> +			clock-names = "core", "iface";
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&blsp1_i2c6_pins>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +		};
compatible
reg
interrupts
clocks
clock-names
pinctrl-0
pinctrl-names
addrsizecells
status

to make it coherent ish with new nodes being added today

I know it's rather incoherent with what's in the file, but I guess
my wunderwaffe dt sorter script is still on the back burner..

Konrad