[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230902053044.GJ3390869@ZenIV>
Date: Sat, 2 Sep 2023 06:30:44 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Takashi Iwai <tiwai@...e.de>
Cc: alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/25] ALSA: pcm: Add copy ops with iov_iter
On Tue, Aug 15, 2023 at 09:01:13PM +0200, Takashi Iwai wrote:
> - if (copy_from_user(get_dma_ptr(substream->runtime, channel, hwoff),
> - (void __user *)buf, bytes))
> + if (!copy_from_iter(get_dma_ptr(substream->runtime, channel, hwoff),
> + bytes, iter))
The former is "if not everything got copied", the latter - "if nothing got
copied"; the same goes for other places like that.
Powered by blists - more mailing lists