linux-kernel - Re: [PATCH v2 02/25] ALSA: pcm: Add copy ops with iov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87edjhm7x1.wl-tiwai@suse.de>
Date:   Sat, 02 Sep 2023 08:00:10 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/25] ALSA: pcm: Add copy ops with iov_iter

On Sat, 02 Sep 2023 07:30:44 +0200,
Al Viro wrote:
> 
> On Tue, Aug 15, 2023 at 09:01:13PM +0200, Takashi Iwai wrote:
> 
> > -	if (copy_from_user(get_dma_ptr(substream->runtime, channel, hwoff),
> > -			   (void __user *)buf, bytes))
> > +	if (!copy_from_iter(get_dma_ptr(substream->runtime, channel, hwoff),
> > +			    bytes, iter))
> 
> The former is "if not everything got copied", the latter - "if nothing got
> copied"; the same goes for other places like that.

Thanks, yes, this should be
	if (copy_from_iter(...) != bytes)

Other places have been already corrected in v2 patchset, but this
place was overseen.  Will fix it.


Takashi