linux-kernel - Re: [PATCH v2] iio: irsd200: fix -Warray-bounds bug in irsd200_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230903120231.04aebf65@jic23-huawei>
Date:   Sun, 3 Sep 2023 12:02:31 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Waqar Hameed <waqar.hameed@...s.com>
Cc:     "GONG, Ruiqi" <gongruiqi@...weicloud.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        "Kees Cook" <keescook@...omium.org>, <linux-iio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-hardening@...r.kernel.org>,
        "Wang Weiyang" <wangweiyang2@...wei.com>,
        Xiu Jianfeng <xiujianfeng@...wei.com>, <gongruiqi1@...wei.com>
Subject: Re: [PATCH v2] iio: irsd200: fix -Warray-bounds bug in
 irsd200_trigger_handler

On Mon, 21 Aug 2023 15:41:18 +0200
Waqar Hameed <waqar.hameed@...s.com> wrote:

> On Thu, Aug 10, 2023 at 11:59 +0800 "GONG, Ruiqi" <gongruiqi@...weicloud.com> wrote:
> 
> > From: "GONG, Ruiqi" <gongruiqi1@...wei.com>
> >
> > When compiling with gcc 13 with -Warray-bounds enabled:
> >
> > In file included from drivers/iio/proximity/irsd200.c:15:
> > In function ‘iio_push_to_buffers_with_timestamp’,
> >     inlined from ‘irsd200_trigger_handler’ at drivers/iio/proximity/irsd200.c:770:2:
> > ./include/linux/iio/buffer.h:42:46: error: array subscript ‘int64_t {aka long long int}[0]’
> > is partly outside array bounds of ‘s16[1]’ {aka ‘short int[1]’} [-Werror=array-bounds=]
> >    42 |                 ((int64_t *)data)[ts_offset] = timestamp;
> >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
> > drivers/iio/proximity/irsd200.c: In function ‘irsd200_trigger_handler’:
> > drivers/iio/proximity/irsd200.c:763:13: note: object ‘buf’ of size 2
> >   763 |         s16 buf = 0;
> >       |             ^~~
> >
> > The problem seems to be that irsd200_trigger_handler() is taking a s16
> > variable as an int64_t buffer. As Jonathan suggested [1], fix it by
> > extending the buffer to a two-element array of s64.
> >
> > Link: https://github.com/KSPP/linux/issues/331
> > Link: https://lore.kernel.org/lkml/20230809181329.46c00a5d@jic23-huawei/ [1]
> > Fixes: 3db3562bc66e ("iio: Add driver for Murata IRS-D200")
> > Signed-off-by: GONG, Ruiqi <gongruiqi1@...wei.com>
> > Acked-by: Gustavo A. R. Silva <gustavoars@...nel.org>  
> 
> Reviewed-by: Waqar Hameed <waqar.hameed@...s.com>
> Tested-by: Waqar Hameed <waqar.hameed@...s.com>

Applied to the fixes-togreg branch of iio.git.  However as we are mid
merge window that tree has an odd base and I'll wait to rebase it on rc1 before
sending a pull request.

Thanks,

Jonathan