linux-kernel - Re: [PATCH v3 0/4] Match data improvements for mcp4725 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230903131505.7a2bd3c3@jic23-huawei>
Date:   Sun, 3 Sep 2023 13:15:05 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Biju Das <biju.das.jz@...renesas.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Marek Vasut <marex@...x.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Biju Das <biju.das.au@...il.com>
Subject: Re: [PATCH v3 0/4] Match data improvements for mcp4725 driver

On Sun,  3 Sep 2023 12:55:44 +0100
Biju Das <biju.das.jz@...renesas.com> wrote:

> This patch series aims to add match data improvements for mcp4725 driver.
> 
> This patch series is only compile tested.
> 
> v2->v3:
>  * Added struct mcp4725_chip_info with chan_spec and chip_id variable and
>    used that as OF/ID table match data.
>  * Added variables use_ext_ref_voltage and dac_reg_offset to struct
>    mcp4725_chip_info to handle hw differences between mcp4725 and
>    mcp4726.
> v1->v2:
>  * Update commit description with reason for change.
> 
> Biju Das (4):
>   iio: dac: mcp4725: Replace variable 'id' from struct mcp4725_data
>   iio: dac: mcp4725: Use i2c_get_match_data()
>   iio: dac: mcp4725: Add use_ext_ref_voltage to struct mcp4725_chip_info
>   iio: dac: mcp4725: Add dac_reg_offset to struct mcp4725_chip_info
> 
>  drivers/iio/dac/mcp4725.c | 42 ++++++++++++++++++++++++++-------------
>  1 file changed, 28 insertions(+), 14 deletions(-)
> 

I've applied this, but still plenty of time for more comments as I'll only
be pushing it out as a non rebasing tree after rc1.

Thanks,

Jonathan