linux-kernel - Re: [PATCH net-next 0/2] net: qrtr: Few qrtr fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <290c7e5e-ddbb-c754-240f-a3017fed3801@quicinc.com>
Date:   Sun, 3 Sep 2023 17:56:36 +0530
From:   Sricharan Ramabadhran <quic_srichara@...cinc.com>
To:     Simon Horman <horms@...nel.org>
CC:     <mani@...nel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
        <kuba@...nel.org>, <pabeni@...hat.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <quic_viswanat@...cinc.com>
Subject: Re: [PATCH net-next 0/2] net: qrtr: Few qrtr fixes

Hi Simon,

On 9/1/2023 7:49 PM, Simon Horman wrote:
> On Fri, Sep 01, 2023 at 03:50:19PM +0530, Sricharan Ramabadhran wrote:
>> Patch #1 fixes a race condition between qrtr driver and ns opening and
>> sending data to a control port.
>>
>> Patch #2 address the issue with legacy targets sending the SSR
>> notifications using DEL_PROC control message.
> 
> Hi Sricharan,
> 
> if these are fixes then they should be targeted at 'net' rather than
> 'net-next', and consideration should be given to supplying Fixes tags.
> 
  There is as such no existing feature broken without these 2 patches
  today. Then they might qualify as preparatory patches for adding
  some features.

> If these are not fixes, then please don't describe them as such.
> In this case targeting net-next is correct, but it is currently closed,
> as per the form letter below.
> 
   Sure, then in that case looks like it belongs to 'net-next' and will
   post V2 once the net-next is opened again.

> In either case please consider:
> 
> * Arranging local variables for new Networking code in
>    reverse xmas tree order - longest line to shortest
> 
> * Avoiding introducing new Sparse warnings
> 
>   ok.

> ## Form letter - net-next-closed
> 
> The merge window for v6.6 has begun and therefore net-next is closed
> for new drivers, features, code refactoring and optimizations.
> We are currently accepting bug fixes only.
> 
> Please repost when net-next reopens after Sept 11th.
> 

  ok, sure.

Regards,
  Sricharan