linux-kernel - Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZPV6CMBlDWriMyva@ashyti-mobl2.lan>
Date:   Mon, 4 Sep 2023 08:32:40 +0200
From:   Andi Shyti <andi.shyti@...ux.intel.com>
To:     Jim Cromie <jim.cromie@...il.com>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, intel-gvt-dev@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org, daniel.vetter@...ll.ch,
        daniel@...ll.ch, jani.nikula@...el.com,
        ville.syrjala@...ux.intel.com, seanpaul@...omium.org,
        robdclark@...il.com, Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
        David Airlie <airlied@...il.com>,
        Imre Deak <imre.deak@...el.com>,
        Radhakrishna Sripada <radhakrishna.sripada@...el.com>,
        Mika Kahola <mika.kahola@...el.com>,
        José Roberto de Souza 
        <jose.souza@...el.com>,
        Ankit Nautiyal <ankit.k.nautiyal@...el.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Matthew Auld <matthew.auld@...el.com>,
        Andi Shyti <andi.shyti@...ux.intel.com>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Rob Clark <robdclark@...omium.org>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Fei Yang <fei.yang@...el.com>
Subject: Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs

Hi Jim,

On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote:
> By at least strong convention, a print-buffer's trailing newline says
> "message complete, send it".  The exception (no TNL, followed by a call
> to pr_cont) proves the general rule.
> 
> Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> 1288 drm_dbg.  Clean up the remainders, in maintainer sized chunks.
> 
> No functional changes.
> 
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>

Reviewed-by: Andi Shyti <andi.shyti@...ux.intel.com> 

Andi