[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZPWCQKgZUUITOUnW@kuha.fi.intel.com>
Date: Mon, 4 Sep 2023 10:07:44 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Utkarsh Patel <utkarsh.h.patel@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
pmalani@...omium.org, chrome-platform@...ts.linux.dev,
andriy.shevchenko@...ux.intel.com, bleung@...omium.org
Subject: Re: [PATCH v2 2/5] usb: typec: Add Active or Passive cable
defination to cable discover mode VDO
On Wed, Aug 30, 2023 at 03:39:47PM -0700, Utkarsh Patel wrote:
> As per USB Type-C Connector specification v2.2 section F.2.6, BIT25
> represents Active or Passive cable. Added BIT25 defination to the
> Thunderbolt 3 cable discover mode VDO.
>
> Signed-off-by: Utkarsh Patel <utkarsh.h.patel@...el.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
> Changes in v2:
> - This change is being added as new patch in this series.
>
> include/linux/usb/typec_tbt.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/usb/typec_tbt.h b/include/linux/usb/typec_tbt.h
> index 63dd44b72e0c..c7a2153bd6f5 100644
> --- a/include/linux/usb/typec_tbt.h
> +++ b/include/linux/usb/typec_tbt.h
> @@ -46,6 +46,7 @@ struct typec_thunderbolt_data {
> #define TBT_CABLE_OPTICAL BIT(21)
> #define TBT_CABLE_RETIMER BIT(22)
> #define TBT_CABLE_LINK_TRAINING BIT(23)
> +#define TBT_CABLE_ACTIVE_PASSIVE BIT(25)
>
> #define TBT_SET_CABLE_SPEED(_s_) (((_s_) & GENMASK(2, 0)) << 16)
> #define TBT_SET_CABLE_ROUNDED(_g_) (((_g_) & GENMASK(1, 0)) << 19)
> --
> 2.25.1
--
heikki
Powered by blists - more mailing lists