linux-kernel - Re: [RFT PATCH 06/15] drm/nouveau: Call drm_atomic_helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a90bc6f4bf16d5aa545e5215f2a5112.mripard@kernel.org>
Date:   Mon, 04 Sep 2023 07:27:45 +0000
From:   "Maxime Ripard" <mripard@...nel.org>
To:     "Douglas Anderson" <dianders@...omium.org>
Cc:     airlied@...il.com, bskeggs@...hat.com, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, kherbst@...hat.com,
        linux-kernel@...r.kernel.org, lyude@...hat.com,
        nouveau@...ts.freedesktop.org, "Maxime Ripard" <mripard@...nel.org>
Subject: Re: [RFT PATCH 06/15] drm/nouveau: Call
 drm_atomic_helper_shutdown() or equiv at shutdown time

On Fri, 1 Sep 2023 16:41:17 -0700, Douglas Anderson wrote:
> Based on grepping through the source code this driver appears to be
> missing a call to drm_atomic_helper_shutdown() (or
> drm_helper_force_disable_all() if not using atomic) at system shutdown
> time. Among other things, this means that if a panel is in use that it
> won't be cleanly powered off at system shutdown time.
> 
> [ ... ]

Reviewed-by: Maxime Ripard <mripard@...nel.org>

Thanks!
Maxime